Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(reuse-lib): adds new writer reuse-lib-writer #1008

Merged
merged 61 commits into from
Jun 12, 2023
Merged

feat(reuse-lib): adds new writer reuse-lib-writer #1008

merged 61 commits into from
Jun 12, 2023

Conversation

cianmSAP
Copy link
Contributor

@cianmSAP cianmSAP commented May 9, 2023 •
edited
Loading

#1006

Adds new writer @sap-ux/ui5-library-writer

@changeset-bot
Copy link

changeset-bot bot commented May 9, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7321bb4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/eslint-plugin-fiori-tools Minor
@sap-ux/ui5-library-writer Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@cianmSAP cianmSAP changed the title Feat/1006/new reuse lib writer feat(reuse-lib): adds new writer reuse-lib-writer May 9, 2023
@cla-assistant
Copy link

cla-assistant bot commented May 25, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@cianmSAP cianmSAP mentioned this pull request May 26, 2023
Closed
2 tasks
@cianmSAP cianmSAP requested a review from tobiasqueck June 9, 2023 14:34
@devinea devinea requested review from a team as code owners June 9, 2023 18:11
@devinea
Copy link
Member

devinea commented Jun 9, 2023

Yes, 100% agree. Please make sure to use the ui5-tooling-transpile module which will also get rid of the src-gen folder requirement and directly transpile from src to dist.

Done in e7fe06c

Also, switched lint script to use @sap-ux/eslint-plugin-fiori-tools and refactored to support libraries.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

devinea
devinea approved these changes Jun 12, 2023
View reviewed changes
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cianmSAP
Tested JS and TS lib locally. Seems to function well.
New writer structure and coding looks good.
JS and TS Templates appear valid.
changeset lg.

@cianmSAP cianmSAP requested a review from tobiasqueck June 12, 2023 12:32
tobiasqueck
tobiasqueck approved these changes Jun 12, 2023
View reviewed changes
Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • well structured, clean and easy to read code
  • great test coverage
  • correct changeset
  • one comment added but that can be done as a follow up

@cianmSAP cianmSAP merged commit 7c70e25 into main Jun 12, 2023
@cianmSAP cianmSAP deleted the feat/1006/new-reuse-lib-writer branch June 12, 2023 13:14
This was referenced Jun 14, 2023
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@devinea devinea devinea approved these changes

@tobiasqueck tobiasqueck tobiasqueck approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cianmSAP @devinea @tobiasqueck