feat(ui5-writer): abstract functions #1040
Merged
+225
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 26c0caa The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Klaus-Keller
requested changes
May 26, 2023
This reverts commit 9debc7e.
…ithub.com/SAP/open-ux-tools into feat/1039/ui5-writer-function-abstraction
Klaus-Keller
previously approved these changes
May 30, 2023
There was a problem hiding this comment.
- I focused review on
@sap-ux/project-access, code changes look good - Test coverage looks good
- Did not build and test locally
- The code smell regarding duplicate enum values is hard to address, because the two different keys point currently to the same value
Approved from my side
devinea
approved these changes
May 31, 2023
|
Kudos, SonarCloud Quality Gate passed! |
Klaus-Keller
approved these changes
May 31, 2023
tobiasqueck
approved these changes
Jun 1, 2023
There was a problem hiding this comment.
Nothing to add to the other two approvals, no issues found in coding or changeset.
Just a comment (no need to change it though): the async await in the factories isn't necessary, just the change to Promise<void> in the factory declaration should have been necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1039