Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore - bump version of @sap-ux/eslint-plugin-fiori-tools used in templates #1070

Merged
merged 3 commits into from
Jun 14, 2023

Conversation

devinea
Copy link
Member

@devinea devinea commented Jun 14, 2023

Chore - bump version of @sap-ux/eslint-plugin-fiori-tools used in templates needed after #1008

@changeset-bot
Copy link

changeset-bot bot commented Jun 14, 2023

🦋 Changeset detected

Latest commit: eb6f5e3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 5 packages
Name Type
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-application-writer Patch
@sap-ux/ui5-library-writer Patch
@sap-ux/generator-simple-fe Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@devinea devinea marked this pull request as ready for review June 14, 2023 08:42
@devinea devinea requested review from a team as code owners June 14, 2023 08:42
Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good.

Copy link
Contributor

@tobiasqueck tobiasqueck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • changeset good
  • version upgrade makes sense

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@devinea
Copy link
Member Author

devinea commented Jun 14, 2023

Thanks @unseen1980 @longieirl @tobiasqueck

@devinea devinea merged commit 743a5dc into main Jun 14, 2023
@devinea devinea deleted the eslint_config_version branch June 14, 2023 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants