Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2821/add generate cap mta #2822

Merged
merged 13 commits into from
Jan 29, 2025
Merged

2821/add generate cap mta #2822

merged 13 commits into from
Jan 29, 2025

Conversation

longieirl
Copy link
Contributor

@longieirl longieirl commented Jan 23, 2025

Fix for #2821

  • Expose a new function generateCAPConfig to generate mta.yaml configuration supporting specific CAP services
    For example, under the hood the following cli commands are executed;
cds add mta xsuaa destination html5-repo hana
npm ci
  • Tests updated to increase code coverage
  • Updated readme highlighting CAP flow

@longieirl longieirl self-assigned this Jan 23, 2025
Copy link

changeset-bot bot commented Jan 23, 2025

🦋 Changeset detected

Latest commit: eb3f45a

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@sap-ux/cf-deploy-config-writer Minor
@sap-ux/cf-deploy-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@longieirl longieirl force-pushed the 2821/add-generate-cap-mta branch from c9f11d0 to a002ed3 Compare January 24, 2025 15:44
@longieirl longieirl marked this pull request as ready for review January 28, 2025 09:47
Copy link
Contributor

@IainSAP IainSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates @longieirl

  • Comments addressed
  • Tests added to cover
  • Not tested locally

Copy link
Contributor

@cianmSAP cianmSAP left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates look good and good test coverage

@longieirl longieirl merged commit 3ff99e2 into main Jan 29, 2025
16 checks passed
@longieirl longieirl deleted the 2821/add-generate-cap-mta branch January 29, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants