Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Bind i18n models with namespace #2830

Merged
merged 11 commits into from
Feb 3, 2025

Conversation

GDamyanov
Copy link
Contributor

Fix for #2829

  • Bind i18n models that contains namespace

@GDamyanov GDamyanov self-assigned this Jan 27, 2025
@GDamyanov GDamyanov requested a review from a team as a code owner January 27, 2025 10:39
Copy link

changeset-bot bot commented Jan 27, 2025

🦋 Changeset detected

Latest commit: e3d0986

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/create Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace requested a review from a team January 27, 2025 10:41
nikmace
nikmace previously approved these changes Jan 27, 2025
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good
Coverage is good
Did not test manually

nikmace
nikmace previously approved these changes Jan 31, 2025
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving
Tests adjusted

Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes looks good
  • Review comments addressed
  • Did not test locally

@nikmace nikmace self-requested a review February 3, 2025 07:30
Copy link
Contributor

@nikmace nikmace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving

@GDamyanov GDamyanov merged commit 6b55228 into main Feb 3, 2025
16 checks passed
@GDamyanov GDamyanov deleted the fix/2829/i18n-models-with-namespace branch February 3, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants