Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fileName property in the change file's content of the manifest change editors writers differs from the name of the change file #2898

Merged
merged 16 commits into from
Feb 19, 2025

Conversation

nikmace
Copy link
Contributor

@nikmace nikmace commented Feb 10, 2025

Fix for #2892.

  • Changes the getChange method to create a correct fileName property that will be the same as the real change file name.
  • fileName property in the change files for the manifest change editors now has three segments with the last one being the change type. fileName and the real file name are now identical.

@nikmace nikmace added bug Something isn't working adp-tooling labels Feb 10, 2025
@nikmace nikmace self-assigned this Feb 10, 2025
@nikmace nikmace requested a review from a team as a code owner February 10, 2025 10:18
Copy link

changeset-bot bot commented Feb 10, 2025

🦋 Changeset detected

Latest commit: fae44a8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@sap-ux/adp-tooling Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/preview-middleware Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@nikmace nikmace changed the title fix: Change fileName for the manifest change editors writers differs from the actual real file name fix: Change fileName for the manifest change editors writers differs from the actual real file name Feb 10, 2025
GDamyanov
GDamyanov previously approved these changes Feb 11, 2025
Copy link
Contributor

@GDamyanov GDamyanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code looks good.
  • Excellent code coverage.
  • Did not tested manually.

@voicis voicis self-requested a review February 17, 2025 06:40
@nikmace nikmace requested a review from testojs February 17, 2025 08:24
@nikmace nikmace changed the title fix: Change fileName for the manifest change editors writers differs from the actual real file name fix: fileName property in the change file's content of the manifest change editors writers differs from the name of the change file Feb 17, 2025
@nikmace nikmace requested a review from voicis February 17, 2025 15:12
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • code changes looks good
  • review comments addressed
  • good test coverage
  • did not test locally

Copy link
Contributor

@testojs testojs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • change looks good
  • changeset OK
  • good test coverage
  • not tested manually

@nikmace nikmace merged commit bb38bef into main Feb 19, 2025
16 checks passed
@nikmace nikmace deleted the feat/2892/diff-file-names branch February 19, 2025 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
adp-tooling bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants