-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fileName
property in the change file's content of the manifest change editors writers differs from the name of the change file
#2898
Conversation
🦋 Changeset detectedLatest commit: fae44a8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
fileName
for the manifest change editors writers differs from the actual real file name
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Code looks good.
- Excellent code coverage.
- Did not tested manually.
fileName
for the manifest change editors writers differs from the actual real file namefileName
property in the change file's content of the manifest change editors writers differs from the name of the change file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- code changes looks good
- review comments addressed
- good test coverage
- did not test locally
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- change looks good
- changeset OK
- good test coverage
- not tested manually
Fix for #2892.
getChange
method to create a correctfileName
property that will be the same as the real change file name.fileName
property in the change files for the manifest change editors now has three segments with the last one being the change type.fileName
and the real file name are now identical.