Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow controller extensions for reuse components on OnPremise systems #2947

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

feat: allow controller extensions for reuse components on OnPremise systems #2947

wants to merge 13 commits into from

Conversation

mmilko01
Copy link
Contributor

@mmilko01 mmilko01 commented Feb 19, 2025 •
edited
Loading

#2946

  • Adds a detection of the type of backend system being used and allows the extension of reuse components for OnPremise/Private Cloud system.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Feb 19, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: c12c98d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@sap-ux/adp-tooling Patch
@sap-ux-private/preview-middleware-client Patch
@sap-ux/preview-middleware Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@mmilko01 mmilko01 marked this pull request as ready for review February 27, 2025 07:33
@mmilko01 mmilko01 requested review from a team as code owners February 27, 2025 07:33
@mmilko01 mmilko01 added feature New feature or request preview-middleware @sap-ux/preview-middleware adp-tooling preview-middleware-client labels Feb 27, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
96.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

voicis
voicis approved these changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@voicis voicis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code changes looks good
  • Good test coverage
  • Did not test locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@voicis voicis voicis approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
adp-tooling feature New feature or request preview-middleware @sap-ux/preview-middleware preview-middleware-client
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mmilko01 @voicis