Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Export functions for Manifest Version Retrieval, and UI5 Version Info #2966

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

kjose90
Copy link
Member

@kjose90 kjose90 commented Feb 27, 2025

The following exports have been added to improve reusability:

  • Exported getManifestVersion from @sap-ux/ui5-application-writer
  • Exported ui5VersionRequestInfo & defaultMinUi5Version from @sap-ux/ui5-info

Copy link

changeset-bot bot commented Feb 27, 2025

🦋 Changeset detected

Latest commit: 6be5a30

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 24 packages
Name Type
@sap-ux/ui5-application-writer Minor
@sap-ux/ui5-info Minor
@sap-ux/fiori-elements-writer Patch
@sap-ux/fiori-freestyle-writer Patch
@sap-ux/ui5-test-writer Patch
@sap-ux/generator-simple-fe Patch
@sap-ux/inquirer-common Patch
@sap-ux/launch-config Patch
@sap-ux/preview-middleware Patch
@sap-ux/ui5-application-inquirer Patch
@sap-ux/ui5-library-inquirer Patch
@sap-ux/ui5-library-sub-generator Patch
@sap-ux/odata-service-inquirer Patch
@sap-ux/abap-deploy-config-inquirer Patch
@sap-ux/adp-flp-config-sub-generator Patch
@sap-ux/adp-tooling Patch
@sap-ux/cf-deploy-config-inquirer Patch
@sap-ux/cf-deploy-config-sub-generator Patch
@sap-ux/create Patch
@sap-ux/flp-config-inquirer Patch
@sap-ux/flp-config-sub-generator Patch
@sap-ux/ui5-library-reference-inquirer Patch
@sap-ux/abap-deploy-config-sub-generator Patch
@sap-ux/ui5-library-reference-sub-generator Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kjose90 kjose90 changed the title feat: Export functions for TLS Patching, Manifest Version Retrieval, and UI5 Version Info feat: Export functions for Manifest Version Retrieval, and UI5 Version Info Feb 27, 2025
@kjose90 kjose90 marked this pull request as ready for review February 27, 2025 12:57
@kjose90 kjose90 requested a review from a team as a code owner February 27, 2025 12:58
Copy link
Member

@devinea devinea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lg

Copy link
Contributor

@longieirl longieirl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changeset is good.
Straight forward exports.
ltgm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants