feat(preview-middleware): introduce new flp homepage #2967
Conversation
🦋 Changeset detectedLatest commit: f2bd7f3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
|
@ui5red maybe we need to increase the timeouts in case the integration tests keep failing in the changed setup. I re-triggered them. Let's see 🤞🏻 |
ui5red
added
preview-middleware
| } | ||
| }, | ||
| "sap.ui5": { | ||
| "flexEnabled": true, |
There was a problem hiding this comment.
Not sure if flexEnabled makes sense for the preview 🤔
| "minUI5Version": "${sap.ui5.dist.version}", | ||
| "libs": { | ||
| "sap.ui.core": { | ||
| "lazy": false |
There was a problem hiding this comment.
Why disable lazy loading? Isn't sap.ui.core anyway loaded via the ui5 bootstrap?
| "lazy": false | ||
| }, | ||
| "sap.cux.home": { | ||
| "lazy": false |
There was a problem hiding this comment.
Same here: Why do we disable lazy loading?
| let scenario: string = ''; | ||
| const ui5VersionInfo = await getUi5Version(); | ||
| // Register RTA if configured | ||
| if (flex) { | ||
| const flexSettings = JSON.parse(flex) as FlexSettings; | ||
| scenario = flexSettings.scenario; | ||
| container.attachRendererCreatedEvent(async function () { | ||
| const triggerAdaptation = async function () { |
There was a problem hiding this comment.
For the sake of clean code and reducing cognitive complexity could we maybe have this as a separate function on root level instead of an nested function property?
| @@ -24,6 +24,7 @@ When this middleware is used together with the `reload-middleware`, then the ord | |||
| | `flp.apps` | `array` | `undefined` | Optional additional local apps that are available in local Fiori launchpad | | |||
| | `flp.libs` | `boolean` | `undefined` | Optional flag to add a generic script fetching the paths of used libraries not available in UI5. To disable set it to `false`, if not set, then the project is checked for a `load-reuse-libs` script and if available the libraries are fetched as well. | | |||
| | `flp.theme` | `string` | `undefined` | Optional flag for setting the UI5 Theme. | | |||
| | `flp.newHomePage` | `boolean` | `undefined` | Optional flag for enabling new FLP Homepage. | | |||
There was a problem hiding this comment.
I'm not quite sure about the naming of this property as new* will become old* over time. Isn't there a unique name for this concept? Or just something like useHomePage?
| vizConfig: { | ||
| 'sap.app': { | ||
| title: string; | ||
| subTitle: string; | ||
| }; | ||
| 'sap.flp': { | ||
| target: { | ||
| appId: string; | ||
| inboundId: string; | ||
| parameters: { | ||
| name: string; | ||
| value: string; | ||
| }[]; | ||
| }; | ||
| }; | ||
| }; |
There was a problem hiding this comment.
I'd suggest to define the type like this:
vizConfig: {
sap: {
app: {
title: string;
subTitle: string;
};
flp': {
target: {
appId: string;
inboundId: string;
parameters: {
name: string;
value: string;
}[];
};
};
}
};also for FLPApp ↓
| "SAP_BASIS_PG_UI_MYHOME": { | ||
| "identification": { | ||
| "id": "SAP_BASIS_PG_UI_MYHOME", | ||
| "title": "My Home" |
There was a problem hiding this comment.
Do we need i18n for this?
| "sections": { | ||
| "homeAppsSection": { | ||
| "id": "homeAppsSection", | ||
| "title": "Recently Added Apps", |
There was a problem hiding this comment.
Do we need i18n for this?
| "homeCatalog": { | ||
| "identification": { | ||
| "id": "homeCatalog", | ||
| "title": "Homepage Apps" |
There was a problem hiding this comment.
Do we need i18n for this?
| @@ -5,7 +5,67 @@ | |||
| <head> | |||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta charset="UTF-8"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"><% if (locals.newHomePage) { %> | |||
There was a problem hiding this comment.
Seeing all these adjustments enclosed in an if statement in the template I was wondering if it would make sense to have an own template html file for the newHomePage scenario. Then we could enhance the getSandboxTemplate function to use UI5 version and newHomePage property as input to fetch the right template. That could help increasing the readability of the html template files. What do you think?
sap.cux.homelibrary controlsflp.newHomePage(false by default)Screenshot:
