From 331ed52ab61192b114facddcb748eba2d49b7a8d Mon Sep 17 00:00:00 2001 From: Max Reichmann Date: Thu, 1 Aug 2024 16:27:48 +0200 Subject: [PATCH] [INTERNAL] Disallow eval in common ESLint config --- eslint.common.config.js | 1 + test/lib/lbt/utils/JSTokenizer.js | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/eslint.common.config.js b/eslint.common.config.js index c2f691503..05da05ea7 100644 --- a/eslint.common.config.js +++ b/eslint.common.config.js @@ -67,6 +67,7 @@ export default [{ "comma-dangle": "off", "no-tabs": "off", "no-console": 2, // Disallow console.log() + "no-eval": 2, // The following rule must be disabled as of ESLint 9. // It's removed and causes issues when present // https://eslint.org/docs/latest/rules/valid-jsdoc diff --git a/test/lib/lbt/utils/JSTokenizer.js b/test/lib/lbt/utils/JSTokenizer.js index f15797925..e1db2f544 100644 --- a/test/lib/lbt/utils/JSTokenizer.js +++ b/test/lib/lbt/utils/JSTokenizer.js @@ -24,7 +24,7 @@ test("valid expressions", function(t) { ]; for (let i = 0; i < list.length; i++) { let evalResult; - eval("evalResult=" + list[i]); + eval("evalResult=" + list[i]); // eslint-disable-line no-eval t.deepEqual(JSTokenizer.parseJS(list[i]), evalResult, "Parse " + list[i]); } });