Skip to content

[ToolbarButton | React | typescript]: Announcement issue when ToolbarButton is made visible #11209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
1 task done
saurabhmehta13 opened this issue Mar 28, 2025 · 4 comments · May be fixed by #11365
Open
1 task done
Assignees
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC P

Comments

@saurabhmehta13
Copy link

Bug Description

We are using two ToolbarButton buttons. When user clicks on one button (Enter full screen), the button triggering the action will be hidden and another button (Exit full screen) will be rendered.
In this case, the focus is correctly working but screen reader tools (mac voiceover, JAWS and NVDA) aren't announcing "Button", only ToolbarButton icon help text is getting announcement.
As per accessibility guidelines, whenever ToolbarButton is in focus, it should announce "text" followed by "button", for example "Enter full screen button".

Affected Component

No response

Expected Behaviour

As per accessibility guidelines, whenever ToolbarButton is in focus, it should announce "text" followed by "button", for example "Enter full screen button".

Isolated Example

https://codesandbox.io/p/sandbox/ui5-webcomponents-react-template-29l34

Steps to Reproduce

  1. Run following code: https://codesandbox.io/p/sandbox/ui5-webcomponents-react-template-29l34
  2. Use any screenreader tool and follow the steps as per attached recording

Log Output, Stack Trace or Screenshots

No response

Priority

None

UI5 Web Components Version

2.8.0

Browser

Chrome

Operating System

No response

Additional Context

No response

Organization

No response

Declaration

  • I’m not disclosing any internal or sensitive information.
@saurabhmehta13 saurabhmehta13 added the bug This issue is a bug in the code label Mar 28, 2025
@saurabhmehta13
Copy link
Author

Recording for more details about the issue with Mac voiceover

Button_toggle_issue.mov

@s-todorova s-todorova self-assigned this Mar 28, 2025
@s-todorova
Copy link
Contributor

Hi @saurabhmehta13,

Thank you for reporting this. It seems like you pasted the default template in the link for the reproducible sample - there aren't any buttons or any other code different from the starter template. Could you please update with the correct link to the reproducible example so I can test?

Best,
Siyana

@saurabhmehta13
Copy link
Author

Here you go - https://codesandbox.io/p/sandbox/clever-browser-k7h2rc
Btw the recording is also shared in the following comment - #11209 (comment)

@s-todorova
Copy link
Contributor

Hello @SAP/ui5-webcomponents-topic-p,

Issue occurs as described on the linked sandbox and in the vanilla ui5 components playground. Tested with JAWS.

Could you please take a look?

Regards,
Siyana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ACC bug This issue is a bug in the code Medium Prio TOPIC P
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

3 participants