Bug: app crashed at ~LibXMLDocument because of xmlFreeDoc be called multiple times

[bruceeelin]

Version:

• svgNativeCoder: 0.2.0
• SDWebImage: 5.19.1

Crashed iOS Version:
17.5, 17.6, 16.7, etc

Recently, we enabled the svg image loading feature in the app to be used with SDWebImage, which we introduced in the AppDelegate using this method:

SDImageSVGNativeCoder *SVGCoder = [SDImageSVGNativeCoder sharedCoder];
[[SDImageCodersManager sharedManager] addCoder:SVGCoder];

When using it, it is the same as loading a normal image, and there is no superfluous operation.
We've been running the online app for a week, and some users have crashes, and the stack monitored by Firebase looks like this:

This happens because the pointer is released multiple times during ~libXMLDocument(), and this bug can be replicated by adding the following code when debugging:

~LibXMLDocument()
{
    xmlFreeDoc(mDocument);
    xmlFreeDoc(mDocument); //  new added
    xmlCleanupParser();
}

I can't analyze under what scenario this crash occurs and why the pointer is released multiple times, I hope you can help look at the specific problem, thank you very much for your help

[missingems]

Same, I am facing this issue as well.

[apparition47]

I'm seeing the same issue too; it crashes frequently.

I noticed svgnative-Xcode compiles with LibXMLParser if it's available. I switched it out for RapidXMLParser and I haven't seen any crashes so far (haven't tried ExpatXMLParser). To do this, you just need to change the file exclusions either in the Package.swift or podspec in svgnative-Xcode. svg-native-viewer will compile with whichever one of the 3 available ~XMLParser.

For example:

            exclude: ["svgnative/src/win",
                      "svgnative/src/xml/ExpatXMLParser.cpp",
-                      "svgnative/src/xml/RapidXMLParser.cpp",
+                      "svgnative/src/xml/LibXMLParser.cpp",

EDIT: opened a PR on svgnative-Xcode to make this the default.

[Eggers-CGI]

Hey, can we get an update here?
Is there a problem it will not be merged?
We are waiting for this repo to accept the Merge-Request to solve a bug with concurrency issues.