[update] fix feddyn

Author: dunzeng

datasets/mnist/train/data0.pkl

@@ -20,7 +20,8 @@ def setup_optim(self, alpha):
 
     def global_update(self, buffer):
         parameters_list = [ele[0] for ele in buffer]
-        self.h = self.h - self.alpha * (1.0/self.num_clients) * (sum(parameters_list) - self.model_parameters)
+        deltas = sum([parameters-self.model_parameters for parameters in parameters_list])
+        self.h = self.h - self.alpha * (1.0/self.num_clients) * deltas
         new_parameters = Aggregators.fedavg_aggregate(parameters_list) - 1.0 / self.alpha * self.h
         self.set_model(new_parameters)
 

datasets/mnist/train/data1.pkl

@@ -78,7 +78,10 @@ def train(self, model_parameters, train_loader, mu) -> None:
         """Client trains its local model on local dataset.
 
         Args:
-            model_parameters (torch.Tensor): Serialized model parameters.
+            model_parameters (torch.Tensor): serialized model parameters.
+            train_loader (torch.utils.data.DataLoader): :class:`torch.utils.data.DataLoader` for this client.
+            mu (float): parameter of FedProx.
+            
         """
         self.set_model(model_parameters)
         frz_model = deepcopy(self._model)

fedlab/contrib/algorithm/feddyn.py

@@ -273,7 +273,7 @@
  ],
  "metadata": {
   "kernelspec": {
-   "display_name": "Python 3.10.0 ('fedlab')",
+   "display_name": "Python 3 (ipykernel)",
    "language": "python",
    "name": "python3"
   },
@@ -287,7 +287,7 @@
    "name": "python",
    "nbconvert_exporter": "python",
    "pygments_lexer": "ipython3",
-   "version": "3.10.0"
+   "version": "3.9.12"
   },
   "vscode": {
    "interpreter": {