Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenLensIO terminology should match OpenTrackIO terminology for distortion and projection offsets #159

Closed
JGoldstone opened this issue Feb 8, 2025 · 1 comment
Assignees

Comments

@JGoldstone
Copy link
Contributor

Quoting Hendrik:

In the OpenLensIO documentation, parameters "distortion center shift" and "perspective shift" are defined. In the OpenTrackIO documentation they seem to be called "distortionOffset" and "projectionOffset". I believe we should stick to one name for each in both documents. I have no problem with using "distortionOffset" and "projectionOffset" but then they should be used in the OpenLensIO documentation as well...

If we are to make the two consistent, one needs to choose which one wins. Hendrik votes above for the "...offset" versions. If that's what we do, there is no change that needs to be made to the code, but whomever is maintaining the doc needs to change it there.

Is the OpenLensIO doc part of the 1.0.0 camdkit release, or is it separate and on a separate schedule?

@jamesmosys
Copy link
Collaborator

Agreed - offset is correct. I will arrange for the OpenLensIO white paper to be updated. Yes the OpenLensIO is part of the v1 OpenTrackIO release, and the final paper will be checked in here.
I will leave this open until the v1 OpenLensIO docs are checked in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants