You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In the OpenLensIO documentation, parameters "distortion center shift" and "perspective shift" are defined. In the OpenTrackIO documentation they seem to be called "distortionOffset" and "projectionOffset". I believe we should stick to one name for each in both documents. I have no problem with using "distortionOffset" and "projectionOffset" but then they should be used in the OpenLensIO documentation as well...
If we are to make the two consistent, one needs to choose which one wins. Hendrik votes above for the "...offset" versions. If that's what we do, there is no change that needs to be made to the code, but whomever is maintaining the doc needs to change it there.
Is the OpenLensIO doc part of the 1.0.0 camdkit release, or is it separate and on a separate schedule?
The text was updated successfully, but these errors were encountered:
Agreed - offset is correct. I will arrange for the OpenLensIO white paper to be updated. Yes the OpenLensIO is part of the v1 OpenTrackIO release, and the final paper will be checked in here.
I will leave this open until the v1 OpenLensIO docs are checked in.
Quoting Hendrik:
If we are to make the two consistent, one needs to choose which one wins. Hendrik votes above for the "...offset" versions. If that's what we do, there is no change that needs to be made to the code, but whomever is maintaining the doc needs to change it there.
Is the OpenLensIO doc part of the 1.0.0 camdkit release, or is it separate and on a separate schedule?
The text was updated successfully, but these errors were encountered: