fix lint and security error

franklinpashok · franklinpashok · commit bd8a81d3d1f9 · 2024-02-21T13:35:34.000+08:00
diff --git a/modules/logging_configuration/local.tf b/modules/logging_configuration/local.tf
@@ -1,5 +1,5 @@
-# tflint-ignore: terraform_unused_declarations
 locals {
+# tflint-ignore: terraform_unused_declarations
   cloudwatch_log_group_name = var.enable_logging ? (var.override_cloudwatch_log_group_name != "" ? var.override_cloudwatch_log_group_name : aws_cloudwatch_log_group.cloudwatch_log_group[0].arn) : ""
   account_id                = data.aws_caller_identity.current.account_id
   aws_region                = data.aws_region.current.name
diff --git a/modules/logging_configuration/main.tf b/modules/logging_configuration/main.tf
@@ -28,8 +28,8 @@ resource "aws_verifiedaccess_instance_logging_configuration" "this" {
 
 }
 
-#checkov:skip=CKV_AWS_338:Ensure CloudWatch log groups retains logs for at least 1 year
 resource "aws_cloudwatch_log_group" "cloudwatch_log_group" {
+#checkov:skip=CKV_AWS_338:Ensure CloudWatch log groups retains logs for at least 1 year
   count             = var.create_cloudwatch_log_group && var.enable_logging ? 1 : 0
   name              = var.cloudwatch_log_group_name
   kms_key_id        = aws_kms_key.log_encryption_key.arn

Original file line number	Diff line number	Diff line change
`@@ -28,8 +28,8 @@ resource "aws_verifiedaccess_instance_logging_configuration" "this" {`
`28`	`28`
`29`	`29`	`}`
`30`	`30`
`31`		`-#checkov:skip=CKV_AWS_338:Ensure CloudWatch log groups retains logs for at least 1 year`
`32`	`31`	`resource "aws_cloudwatch_log_group" "cloudwatch_log_group" {`
	`32`	`+#checkov:skip=CKV_AWS_338:Ensure CloudWatch log groups retains logs for at least 1 year`
`33`	`33`	`count = var.create_cloudwatch_log_group && var.enable_logging ? 1 : 0`
`34`	`34`	`name = var.cloudwatch_log_group_name`
`35`	`35`	`kms_key_id = aws_kms_key.log_encryption_key.arn`