Skip to content

Commit 943de4f

Browse files
committed
usecallback to be safe for handleiconclick fct
1 parent d0d83bd commit 943de4f

File tree

1 file changed

+10
-7
lines changed

1 file changed

+10
-7
lines changed

packages/synapse-react-client/src/components/IconList.tsx

Lines changed: 10 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { useMemo } from 'react'
1+
import { useCallback, useMemo } from 'react'
22
import IconSvg, { IconSvgProps } from './IconSvg/IconSvg'
33
import { merge } from 'lodash-es'
44
import { useQueryContext } from './QueryContext'
@@ -34,12 +34,15 @@ function IconList(props: IconListProps) {
3434
const queryContext = useQueryContext()
3535
const { addValueToSelectedFacet } = queryContext
3636

37-
const handleIconClick = (dataType: 'string') => {
38-
const facet: UniqueFacetIdentifier = {
39-
columnName: 'dataType',
40-
}
41-
addValueToSelectedFacet(facet, dataType)
42-
}
37+
const handleIconClick = useCallback(
38+
(dataType: 'string') => {
39+
const facet: UniqueFacetIdentifier = {
40+
columnName: 'dataType',
41+
}
42+
addValueToSelectedFacet(facet, dataType)
43+
},
44+
[addValueToSelectedFacet],
45+
)
4346

4447
const mergedIconConfigs: IconConfigs = useMemo(() => {
4548
const mergedIconConfigs: IconConfigs = {}

0 commit comments

Comments
 (0)