Merge pull request #1541 from nickgros/SWC-7236

Sage-Bionetworks · Jan 31, 2025 · eff9e9f · eff9e9f
2 parents bc7bcfe + 693c516
commit eff9e9f
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 2 deletions.
diff --git a/packages/synapse-react-client/src/components/SynapseTable/SynapseTable.tsx b/packages/synapse-react-client/src/components/SynapseTable/SynapseTable.tsx
@@ -153,6 +153,7 @@ export function SynapseTable(props: SynapseTableProps) {
           id: selectColumn.name,
           enableSorting: isSortableColumn(selectColumn.columnType),
           enableResizing: true,
+          size: 200,
           header: TableDataColumnHeader,
           cell: TableDataCell,
         })

diff --git a/packages/synapse-react-client/src/components/TanStackTable/StyledTanStackTable.tsx b/packages/synapse-react-client/src/components/TanStackTable/StyledTanStackTable.tsx
@@ -73,10 +73,15 @@ export default function StyledTanStackTable<
         header.column.getSize()
     }
     return colSizes
+    // Intentionally limit the dependencies to only recompute when the column sizes change
     // eslint-disable-next-line react-hooks/exhaustive-deps
-  }, [table.getState().columnSizingInfo, table.getState().columnSizing])
+  }, [
+    table.getState().columnSizingInfo,
+    table.getState().columnSizing,
+    table.getState().columnVisibility, // If a column is added, its width should be recalculated
+  ])
 
-  const tableWidth = fullWidth ? '100%' : table.getTotalSize()
+  const tableWidth = fullWidth ? '100%' : `${table.getTotalSize()}px`
 
   /* When resizing any column we will render this special memoized version of our table body */
   const TableBodyElement = table.getState().columnSizingInfo.isResizingColumn
@@ -89,6 +94,7 @@ export default function StyledTanStackTable<
         {...tableSlotProps}
         style={{
           ...columnSizeVars,
+          tableLayout: 'fixed',
           width: tableWidth,
           ...tableSlotProps['style'],
         }}