Skip to content

Commit 84c83b1

Browse files
committed
update paths for change detection and rendering
1 parent 6d8e799 commit 84c83b1

File tree

5 files changed

+33
-23
lines changed

5 files changed

+33
-23
lines changed

modules/dense_correspondence_manipulation/change_detection/change_detection.py

Lines changed: 15 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -76,6 +76,20 @@ class ChangeDetection(object):
7676

7777
def __init__(self, app, view, cameraIntrinsics=None, debug=True,
7878
data_directory=None):
79+
"""
80+
This shouldn't be called directly. Should only be called via the staticmethod from_data_folder
81+
82+
:param app:
83+
:type app:
84+
:param view:
85+
:type view:
86+
:param cameraIntrinsics:
87+
:type cameraIntrinsics:
88+
:param debug:
89+
:type debug:
90+
:param data_directory: The 'processed' subfolder of a top level log folder
91+
:type data_directory:
92+
"""
7993

8094
self.app = app
8195
self.views = dict()
@@ -119,23 +133,6 @@ def __init__(self, app, view, cameraIntrinsics=None, debug=True,
119133
# dock.setMinimumWidth(300)
120134
# dock.setMinimumHeight(300)
121135

122-
if data_directory is not None:
123-
self.data_dir = data_directory
124-
self.loadData()
125-
126-
def loadData(self):
127-
"""
128-
Load the relevant data from the folder.
129-
130-
Key pieces of data are
131-
- background reconstruction
132-
- foreground reconstruction
133-
- images (depth and rgb)
134-
- camera pose data
135-
- camera intrinsics
136-
"""
137-
self.image_dir = os.path.join(self.data_dir, 'images')
138-
139136
@property
140137
def background_reconstruction(self):
141138
return self._background_reconstruction
@@ -502,7 +499,7 @@ def from_data_folder(data_folder, config=None, globalsDict=None, background_data
502499
app = globalsDict['app']
503500

504501

505-
camera_info_file = os.path.join(data_folder, 'processed', 'images', 'camera_info.yaml')
502+
camera_info_file = os.path.join(data_folder, 'images', 'camera_info.yaml')
506503
camera_intrinsics = utils.CameraIntrinsics.from_yaml_file(camera_info_file)
507504
changeDetection = ChangeDetection(app, view, cameraIntrinsics=camera_intrinsics)
508505
changeDetection.foreground_reconstruction = foreground_reconstruction

modules/dense_correspondence_manipulation/fusion/fusion_reconstruction.py

Lines changed: 14 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,17 @@ def visualize_reconstruction(self, view, vis_uncropped=False, name=None):
322322

323323
@staticmethod
324324
def from_data_folder(data_folder, config=None, name=None):
325+
"""
326+
327+
:param data_folder: The 'processed' subfolder of a top level log folder
328+
:type data_folder:
329+
:param config:
330+
:type config:
331+
:param name:
332+
:type name:
333+
:return:
334+
:rtype:
335+
"""
325336
fr = TSDFReconstruction()
326337
fr.data_dir = data_folder
327338

@@ -332,14 +343,14 @@ def from_data_folder(data_folder, config=None, name=None):
332343
print "no config passed in, loading default"
333344
config = FusionReconstruction.load_default_config()
334345

335-
pose_data_filename = os.path.join(data_folder, 'processed', 'images', 'pose_data.yaml')
336-
camera_info_filename = os.path.join(data_folder, 'processed', 'images', 'camera_info.yaml')
346+
pose_data_filename = os.path.join(data_folder, 'images', 'pose_data.yaml')
347+
camera_info_filename = os.path.join(data_folder, 'images', 'camera_info.yaml')
337348

338349
fr.config = config
339350
fr.name = name
340351
fr.kinematics_pose_data = utils.getDictFromYamlFilename(pose_data_filename)
341352
fr.camera_info = utils.getDictFromYamlFilename(camera_info_filename)
342353

343-
fr.reconstruction_filename = os.path.join(fr.data_dir, 'processed', 'fusion_mesh.ply')
354+
fr.reconstruction_filename = os.path.join(fr.data_dir, 'fusion_mesh.ply')
344355
fr.setup()
345356
return fr

modules/dense_correspondence_manipulation/scripts/batch_run_change_detection_pipeline.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,8 @@ def main():
2020

2121
for idx, dir in enumerate(list_of_dirs):
2222

23-
data_folder = os.path.join(parent_folder, dir)
23+
log_folder = os.path.join(parent_folder, dir)
24+
data_folder = os.path.join(log_folder, 'processed')
2425

2526
if not os.path.isdir(data_folder):
2627
continue

modules/dense_correspondence_manipulation/scripts/run_change_detection.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ def run(data_folder, config_file=CONFIG_FILE, debug=False, globalsDict=None,
1818
background_scene_data_folder=None):
1919
"""
2020
Runs the change detection pipeline
21-
:param data_dir:
21+
:param data_dir: The 'processed' subfolder of a top-level log folder
2222
:param config_file:
2323
:return:
2424
"""

modules/dense_correspondence_manipulation/scripts/run_change_detection_pipeline.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ def already_ran_change_detection(processed_dir):
5050
return (os.path.isfile(file_to_check_1) and os.path.isfile(file_to_check_2))
5151

5252
def run_on_all_subfolders(directory, config_file):
53+
print "running on all subfolders"
5354

5455
for dir in sorted(os.listdir(directory)):
5556
full_dir = os.path.join(directory, dir)

0 commit comments

Comments
 (0)