Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated Package for google-libphonenumber #236

Open
william-mens opened this issue Apr 30, 2024 · 0 comments
Open

Outdated Package for google-libphonenumber #236

william-mens opened this issue Apr 30, 2024 · 0 comments

Comments

@william-mens
Copy link

Hi Team,
I hope this message finds you well. I am reaching out regarding an issue I encountered while using the Joi-Phone-Number package to validate international phone numbers, specifically Ghana phone numbers.

Upon thorough testing, I discovered that the package is returning validation errors for Ghana numbers starting with the "053" code, even when the strict validation setting is enabled. This issue stems from the outdated "google-libphonenumber" package utilized within Joi-Phone-Number. The PhoneUtil.isValidNumber function from this library inaccurately flags valid Ghana numbers like "0532221114" as invalid.

I believe upgrading the library package to a more recent version will resolve this issue. I am prepared to submit a pull request to address this, pending your approval.
Thank you for considering this request. I look forward to your guidance on how best to proceed with the package update.

Screenshot 2024-04-30 at 10 29 53 AM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant