Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding new services #20

Open
janzheng opened this issue May 20, 2020 · 1 comment
Open

adding new services #20

janzheng opened this issue May 20, 2020 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@janzheng
Copy link

Awesome piece of code! I've added a few academic profile services (ORCID, ResearchGate, Google Scholar, Publons, and ProtocolsIO), and was wondering if you'd like me to do a pull request, or if you just wanted me to add the regexes in here since they're so simple... not sure if it's worth the #effort to do a pull request.

here they are:

orcid: /https?:\/\/(www\.)?orcid\.org\/([^ /\n]+)/ig,
researchgate: /https?:\/\/(www\.)?researchgate\.net\/profile\/([^ /\n]+)/ig,
googlescholar: /https?:\/\/scholar\.google\.com\/citations\?user=([^ /\n]+)/ig,
publons: /https?:\/\/(www\.)?publons\.com\/researcher\/([0-9]{0,9})?\/([^ /\n]+)/ig,
protocolsio: /https?:\/\/(www\.)?protocols\.io\/researchers\/([^ /\n]+)/ig,

and for the typeNameMap:

['orcid', 'ORCID'],
['researchgate', 'ResearchGate'],
['googlescholar', 'GoogleScholar'],
['publons', 'Publons'],
['protocolsio', 'ProtocolsIO'],

cheers

@AdriVanHoudt AdriVanHoudt added the enhancement New feature or request label May 22, 2020
@AdriVanHoudt
Copy link
Contributor

Hi @janzheng
PRs are definitely welcome! Make sure to also update the test.

@AdriVanHoudt AdriVanHoudt added the good first issue Good for newcomers label Sep 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants