Fix overflow in TryGetLiteralAt

ds5678 · gompoc · commit a571fcb7b41a · 2024-12-24T13:24:10.000Z
diff --git a/Cpp2IL.Core/Utils/MiscUtils.cs b/Cpp2IL.Core/Utils/MiscUtils.cs
@@ -101,7 +101,7 @@ internal static string[] GetGenericParams(string input)
 
     public static string? TryGetLiteralAt(Il2CppBinary theDll, ulong rawAddr)
     {
-        if (theDll.RawLength <= (long)rawAddr)
+        if ((ulong)theDll.RawLength <= rawAddr)
             return null;
 
         var c = Convert.ToChar(theDll.GetByteAtRawAddress(rawAddr));

Original file line number	Diff line number	Diff line change
`@@ -101,7 +101,7 @@ internal static string[] GetGenericParams(string input)`
`101`	`101`
`102`	`102`	`public static string? TryGetLiteralAt(Il2CppBinary theDll, ulong rawAddr)`
`103`	`103`	`{`
`104`		`- if (theDll.RawLength <= (long)rawAddr)`
	`104`	`+ if ((ulong)theDll.RawLength <= rawAddr)`
`105`	`105`	`return null;`
`106`	`106`
`107`	`107`	`var c = Convert.ToChar(theDll.GetByteAtRawAddress(rawAddr));`