Lib: Actually use position shift lock when reading string literals

Sam Byass · Sam Byass · commit d0028d40c1a0 · 2022-04-22T22:23:04.000+01:00
diff --git a/LibCpp2IL/Metadata/Il2CppMetadata.cs b/LibCpp2IL/Metadata/Il2CppMetadata.cs
@@ -407,8 +407,8 @@ internal string ReadStringFromIndexNoReadLock(int index)
         public string GetStringLiteralFromIndex(uint index)
         {
             var stringLiteral = stringLiterals[index];
-            Position = metadataHeader.stringLiteralDataOffset + stringLiteral.dataIndex;
-            return Encoding.UTF8.GetString(ReadBytes((int) stringLiteral.length));
+            
+            return Encoding.UTF8.GetString(ReadByteArrayAtRawAddress(metadataHeader.stringLiteralDataOffset + stringLiteral.dataIndex, (int) stringLiteral.length));
         }
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -407,8 +407,8 @@ internal string ReadStringFromIndexNoReadLock(int index)`
`407`	`407`	`public string GetStringLiteralFromIndex(uint index)`
`408`	`408`	`{`
`409`	`409`	`var stringLiteral = stringLiterals[index];`
`410`		`- Position = metadataHeader.stringLiteralDataOffset + stringLiteral.dataIndex;`
`411`		`- return Encoding.UTF8.GetString(ReadBytes((int) stringLiteral.length));`
	`410`	`+`
	`411`	`+ return Encoding.UTF8.GetString(ReadByteArrayAtRawAddress(metadataHeader.stringLiteralDataOffset + stringLiteral.dataIndex, (int) stringLiteral.length));`
`412`	`412`	`}`
`413`	`413`	`}`
`414`	`414`	`}`