Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Benchmark scores update #491

Merged
merged 22 commits into from
Jan 30, 2024
Merged

Benchmark scores update #491

merged 22 commits into from
Jan 30, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 15, 2024 •
edited
Loading

Description

Please include a summary of the change and which is fixed.

  • update scores after re-markup

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@babenek babenek force-pushed the auxiliary branch 6 times, most recently from 0c10279 to 0d587c5 Compare January 23, 2024 17:40
@codecov-commenter
Copy link

codecov-commenter commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ebc531b) 90.44% compared to head (eeefbe0) 90.44%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #491   +/-   ##
=======================================
  Coverage   90.44%   90.44%           
=======================================
  Files         127      127           
  Lines        4335     4335           
  Branches      695      695           
=======================================
  Hits         3921     3921           
  Misses        273      273           
  Partials      141      141

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek changed the title Model retrain test Benchmark scores update Jan 24, 2024
babenek
babenek commented Jan 26, 2024
View reviewed changes
Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback after Samsung/CredData#70

Yullia
Yullia previously approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@Yullia Yullia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@babenek babenek marked this pull request as ready for review January 29, 2024 13:03
@babenek babenek requested a review from a team as a code owner January 29, 2024 13:03
csh519
csh519 approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@csh519 csh519 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the re-mark and benchmark testing.

LGTM 👍

@babenek babenek merged commit 2a53a44 into Samsung:main Jan 30, 2024
23 checks passed
@babenek babenek deleted the auxiliary branch January 30, 2024 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDizzix xDizzix xDizzix approved these changes

@csh519 csh519 csh519 approved these changes

@Yullia Yullia Awaiting requested review from Yullia

@iuriimet iuriimet Awaiting requested review from iuriimet

@kmnls kmnls Awaiting requested review from kmnls

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@babenek @codecov-commenter @xDizzix @Yullia @csh519