Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update rules for token bariers #492

Merged
merged 10 commits into from
Jan 19, 2024
Merged

Update rules for token bariers #492

merged 10 commits into from
Jan 19, 2024

Conversation

babenek
Copy link
Contributor

@babenek babenek commented Jan 16, 2024

Description

Please include a summary of the change and which is fixed.

  • Updated bariers for tokens. Often / is used right with the token in url e.g. /AKIA...
  • do not skip *.rst files in scan - they are text
  • applied multiprocessing download for benchmark

How has this been tested?

Please describe the tests that you ran to verify your changes.

  • UnitTest
  • Benchmark

@codecov-commenter
Copy link

codecov-commenter commented Jan 16, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1371a70) 90.40% compared to head (b17e8a8) 90.44%.
Report is 2 commits behind head on main.

Files Patch % Lines
credsweeper/scanner/scan_type/scan_type.py 91.66% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #492      +/-   ##
==========================================
+ Coverage   90.40%   90.44%   +0.04%     
==========================================
  Files         127      127              
  Lines        4327     4335       +8     
  Branches      693      695       +2     
==========================================
+ Hits         3912     3921       +9     
+ Misses        274      273       -1     
  Partials      141      141              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@babenek babenek changed the title Tokenbar Update rules for token bariers Jan 19, 2024
@babenek babenek marked this pull request as ready for review January 19, 2024 08:26
@babenek babenek requested a review from a team as a code owner January 19, 2024 08:26
Copy link
Contributor Author

@babenek babenek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: rollback after Samsung/CredData#66

Copy link
Contributor

@xDizzix xDizzix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@babenek babenek merged commit 269ff93 into Samsung:main Jan 19, 2024
29 checks passed
@babenek babenek deleted the tokenbar branch January 19, 2024 10:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants