[luci/import] Revise importModule method #13902
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will revise importModule method with circle::Module as - make it private to prevent future isses with large model - add some guards - only call reader with file data and size ONE-DCO-1.0-Signed-off-by: SaeHie Park <[email protected]>
jinevening
reviewed
Sep 3, 2024
| @@ -268,6 +268,10 @@ Importer::Importer() | |||
|
|
|||
| std::unique_ptr<Module> Importer::importModule(const circle::Model *model) const | |||
| { | |||
| assert(model); | |||
There was a problem hiding this comment.
This is checked in importModule(const uint8_t *data, size_t size)
There was a problem hiding this comment.
Thanks for pointing this :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will revise importModule method with circle::Module as