[nnpackage] Add mx dtypes to schema #14299
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds mxfp4 and mxint8 to circle schema. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]>
|
need to revise |
seanshpark
reviewed
Nov 5, 2024
nnpackage/schema/circle_schema.fbs
Outdated
| @@ -35,6 +35,7 @@ | |||
| // Version 0.8: GRU op is added. UINT4 is added. | |||
| // Version 0.9: GGML_Q{X}_{Y} types are added. Weight compression option is added. | |||
| // ROPE op is added. | |||
| // Version 0.10: MXFP4, MXINT8 types are added. | |||
There was a problem hiding this comment.
from previous update PR comment, #14013 (comment) , I think we have to stick to 0.9
glistening
previously approved these changes
Nov 5, 2024
seanshpark
reviewed
Nov 5, 2024
|
I'll merge this PR as @glistening already approved (#14299 (review)). |
BLee-bot
pushed a commit
to BLee-bot/ONE
that referenced
this pull request
Nov 6, 2024
* [nnpackage] Add mx dtypes to schema This adds mxfp4 and mxint8 to circle schema. ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong <[email protected]> * Update version history * Stick to 0.9 * Remove empty line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds mxfp4 and mxint8 to circle schema.
ONE-DCO-1.0-Signed-off-by: Hyukjin Jeong [email protected]
Related to: #14293
Draft PR: #14294