[onert] Remove UNUSED_RELEASE macro #14336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hseok-oh
commented
Nov 21, 2024
| /** | ||
| * @brief To get operand-level info, e.g., ir::Operand::isConstant() | ||
| */ | ||
| const ir::Operands &_operands; |
There was a problem hiding this comment.
_operands is not used in DynamicShapeInferer.
hseok-oh
force-pushed
the
onert_unused_release
branch
from
5cbda8e to
7aa5443
Compare
This commit removes UNUSED_RELEASE() macro in onert. UNUSED_RELEASE() macro is introduced to avoid unused variable warning when the variable is only used in debug build. However, it is not necessary because we can use c++17 [[maybe_unused]] instead. ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
hseok-oh
force-pushed
the
onert_unused_release
branch
from
7aa5443 to
fba7989
Compare
hseok-oh
commented
Nov 21, 2024
Comment on lines
+140
to
+141
| if (weights_format != ir::FullyConnectedWeightsFormat::Default) | ||
| throw std::runtime_error("Unsupported FullyConnected Weights Format"); |
There was a problem hiding this comment.
weights_format param is not used on ruy backend. ruy backend supports default format only.
chunseoklee
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removes UNUSED_RELEASE() macro in onert.
UNUSED_RELEASE() macro is introduced to avoid unused variable warning when the variable is only used in debug build.
However, it is not necessary because we can use c++17 [[maybe_unused]] instead.
ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]