Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[circle-interpreter-cffi-test] Introduce test #14379

Merged
merged 2 commits into from
Dec 1, 2024
Merged

Conversation

mhs4670go
Copy link
Contributor

This commit introduces circle-interpreter-cffi-test to ONE.

Related: #14352
ONE-DCO-1.0-Signed-off-by: seongwoo [email protected]

This commit introduces circle-interpreter-cffi-test to ONE.

ONE-DCO-1.0-Signed-off-by: seongwoo <[email protected]>
@mhs4670go mhs4670go added the PR/ready for review It is ready to review. Please review it. label Nov 28, 2024
@mhs4670go mhs4670go requested a review from a team November 28, 2024 06:35
@mhs4670go mhs4670go requested a review from seanshpark November 28, 2024 08:40
Comment on lines 63 to 65
"""
Decorator to wrap functions with error checking.
"""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit

Suggested change
"""
Decorator to wrap functions with error checking.
"""
"""
Decorator to wrap functions with error checking.
"""

@@ -0,0 +1,17 @@
eval(Add_000)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How did you select this list of Ops?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is from record-minmax-conversion-test as I think it is enough for checking the cffi features and without increasing the test time as much.

jinevening
jinevening previously approved these changes Nov 28, 2024
Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM w/ minor comments.

Copy link
Contributor

@jinevening jinevening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanshpark seanshpark merged commit 39c39a3 into Samsung:master Dec 1, 2024
8 checks passed
@mhs4670go mhs4670go deleted the a6 branch December 2, 2024 07:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants