Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[infra/cmake] Introduce DISABLE_EXTERNAL_WARNING option #14444

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[infra/cmake] Introduce DISABLE_EXTERNAL_WARNING option #14444

merged 1 commit into from
Dec 13, 2024

Conversation

hseok-oh
Copy link
Contributor

This commit introduces DISABLE_EXTERNAL_WARNING option.
It is used to disable warnings from external library build.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh [email protected]

@hseok-oh
[infra/cmake] Introduce DISABLE_EXTERNAL_WARNING option
37e3d3e 
This commit introduces DISABLE_EXTERNAL_WARNING option.
It is used to disable warnings from external library build.

ONE-DCO-1.0-Signed-off-by: Hyeongseok Oh <[email protected]>
@hseok-oh hseok-oh added the PR/ready for review It is ready to review. Please review it. label Dec 12, 2024
@hseok-oh hseok-oh requested a review from seanshpark December 12, 2024 10:55
SlavikMIPT
SlavikMIPT approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@SlavikMIPT SlavikMIPT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hseok-oh
Copy link
Contributor Author

hseok-oh commented Dec 13, 2024 •
edited
Loading

@seanshpark add_extdirectory is also used on compiler build. But default condition (not setting DISABLE_EXTERNAL_WARNING) run same as before. PTAL.

ragmani
ragmani approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@ragmani ragmani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

seanshpark
seanshpark approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@seanshpark seanshpark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thank you!

@hseok-oh hseok-oh merged commit 8f873c5 into Samsung:master Dec 13, 2024
14 checks passed
@hseok-oh hseok-oh deleted the disable_ext_warning branch December 13, 2024 04:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seanshpark seanshpark seanshpark approved these changes

@SlavikMIPT SlavikMIPT SlavikMIPT approved these changes

@ragmani ragmani ragmani approved these changes

Assignees
No one assigned
Labels
PR/ready for review It is ready to review. Please review it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hseok-oh @seanshpark @SlavikMIPT @ragmani