Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing words updated #4826

Open
ivanromakh opened this issue Feb 22, 2023 · 4 comments
Open

Missing words updated #4826

ivanromakh opened this issue Feb 22, 2023 · 4 comments
Assignees
Labels

Comments

@ivanromakh
Copy link
Collaborator

ivanromakh commented Feb 22, 2023

image

ivanromakh added a commit that referenced this issue Feb 22, 2023
@s-steddy
Copy link

s-steddy commented Mar 9, 2023

A little more design finesse needed before this is done. In short the red and green boxes need to look more like the hint boxes - same height, with rounded corners, etc. I've included quite a few pictures so am going to put tasks first and identify them by number.

This is needed on desktop AND mobile:

  • In review, align all answer boxes to a consistent design as is used for hints (see image 4). That is, slightly taller, and with rounded corners. But, lines should not overlap - see 4 and 6.
  • Keep the red - I don't think we use a lighter red and as we change the text to white I don't think a paler colour would definitely be better.
  • But change the green to the lighter shade we use, as seen on pair-match:

image

On mobile:

  • Note there are missing space characters on mobile - compare the sentence that begins "He describes..." in 2 and 5. Clearly related to which field the author has put the punctuation in, but needs a fix as has been done on desktop.
  1. image
  2. image
  3. image
  4. image
  5. image
  6. image

@s-steddy
Copy link

s-steddy commented Mar 9, 2023

@GhadaShebl if you could fix up the design of the answer boxes when you have time, I think this shouldn't be too difficult for you to fix right Ivan?

@s-steddy s-steddy added the Mobile label Mar 9, 2023
@ivanromakh
Copy link
Collaborator Author

@s-steddy I don`t understand what I need to do?

@s-steddy
Copy link

We're nearly finished, all that remains is to get the answer and hint fields aligned, but before we're not quite done.

Answers boxes, whether correct, incorrect, or empty and hint boxes must be same height and same vertical position. This is almost right:
image

But the hint fields are one or two pixels shorter on the bottom. Make sure to check this for both correct and incorrect hints.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants