738 fix check constraints in parameters in IDE-SECIR (#739)

Author: annawendler

cpp/models/ide_secir/model.h

@@ -97,7 +97,7 @@ class Model
                 "Initialization failed. Not enough time points for transitions given before start of simulation.");
         }
 
-        parameters.check_constraints(dt);
+        parameters.check_constraints();
     }
 
     /**

cpp/models/ide_secir/parameters.h

@@ -171,12 +171,13 @@ class Parameters : public ParametersBase
      * @param dt Time step size which is used to get model specific StateAgeFunction%s support.
      * @return Returns true if one (or more) constraint(s) are not satisfied, otherwise false.
      */
-    bool check_constraints(ScalarType dt = 0.1) const
+    bool check_constraints() const
     {
-        size_t check_eval_min = 50; // parameter defining minimal window on x-axis
-        for (size_t i = 0;
-             i < std::min(check_eval_min, (size_t)this->get<TransmissionProbabilityOnContact>().get_support_max(dt));
-             i++) {
+        // For parameters potentially depending on the infectious age, values are checked
+        // equidistantly on a realistic maximum window.
+        // Please note that this is an incomplete check on correctness.
+        size_t infectious_window_check = 50; // parameter defining minimal window on x-axis
+        for (size_t i = 0; i < infectious_window_check; i++) {
             if (this->get<TransmissionProbabilityOnContact>().eval((ScalarType)i) < 0.0 ||
                 this->get<TransmissionProbabilityOnContact>().eval((ScalarType)i) > 1.0) {
                 log_error("Constraint check: TransmissionProbabilityOnContact smaller {:d} or larger {:d} at some "
@@ -186,9 +187,7 @@ class Parameters : public ParametersBase
             }
         }
 
-        for (size_t i = 0;
-             i < std::min(check_eval_min, (size_t)this->get<RelativeTransmissionNoSymptoms>().get_support_max(dt));
-             i++) {
+        for (size_t i = 0; i < infectious_window_check; i++) {
             if (this->get<RelativeTransmissionNoSymptoms>().eval((ScalarType)i) < 0.0 ||
                 this->get<RelativeTransmissionNoSymptoms>().eval((ScalarType)i) > 1.0) {
                 log_error("Constraint check: RelativeTransmissionNoSymptoms smaller {:d} or larger {:d} at some "
@@ -198,9 +197,7 @@ class Parameters : public ParametersBase
             }
         }
 
-        for (size_t i = 0;
-             i < std::min(check_eval_min, (size_t)this->get<RiskOfInfectionFromSymptomatic>().get_support_max(dt));
-             i++) {
+        for (size_t i = 0; i < infectious_window_check; i++) {
             if (this->get<RiskOfInfectionFromSymptomatic>().eval((ScalarType)i) < 0.0 ||
                 this->get<RiskOfInfectionFromSymptomatic>().eval((ScalarType)i) > 1.0) {
                 log_error("Constraint check: RiskOfInfectionFromSymptomatic smaller {:d} or larger {:d} at some "