Skip to content

Commit 9b4ad8d

Browse files
Merge pull request #588 from SciML/deprecations
Removed deprecated functionality
2 parents 15d40bb + 40849d6 commit 9b4ad8d

File tree

4 files changed

+14
-91
lines changed

4 files changed

+14
-91
lines changed

src/LinearSolve.jl

+9-1
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,15 @@ include("solve_function.jl")
138138
include("default.jl")
139139
include("init.jl")
140140
include("adjoint.jl")
141-
include("deprecated.jl")
141+
142+
## Deprecated, remove in July 2025
143+
144+
@static if isdefined(SciMLBase, :DiffEqArrayOperator)
145+
function defaultalg(A::SciMLBase.DiffEqArrayOperator, b,
146+
assump::OperatorAssumptions{Bool})
147+
defaultalg(A.A, b, assump)
148+
end
149+
end
142150

143151
@inline function _notsuccessful(F::LinearAlgebra.QRCompactWY)
144152
(m, n) = size(F)

src/default.jl

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@ end
4545
# For SciML algorithms already using `defaultalg`, all assume square matrix.
4646
defaultalg(A, b) = defaultalg(A, b, OperatorAssumptions(true))
4747

48-
function defaultalg(A::Union{DiffEqArrayOperator, MatrixOperator}, b,
48+
function defaultalg(A::MatrixOperator, b,
4949
assump::OperatorAssumptions{Bool})
5050
defaultalg(A.A, b, assump)
5151
end

src/deprecated.jl

-85
This file was deleted.

test/pardiso/pardiso.jl

+4-4
Original file line numberDiff line numberDiff line change
@@ -54,17 +54,17 @@ prob = LinearProblem(copy(A), copy(b1))
5454

5555
linsolve = init(prob, UMFPACKFactorization())
5656
sol11 = solve!(linsolve)
57-
linsolve = LinearSolve.set_b(sol11.cache, copy(b2))
57+
linsolve.b = copy(b2)
5858
sol12 = solve!(linsolve)
59-
linsolve = LinearSolve.set_A(sol12.cache, copy(A2))
59+
linsolve.A = copy(A2)
6060
sol13 = solve!(linsolve)
6161

6262
for alg in algs
6363
linsolve = init(prob, alg)
6464
sol31 = solve!(linsolve)
65-
linsolve = LinearSolve.set_b(sol31.cache, copy(b2))
65+
linsolve.b = copy(b2)
6666
sol32 = solve!(linsolve)
67-
linsolve = LinearSolve.set_A(sol32.cache, copy(A2))
67+
linsolve.A = copy(A2)
6868
sol33 = solve!(linsolve)
6969
@test sol11.u sol31.u
7070
@test sol12.u sol32.u

0 commit comments

Comments
 (0)