Skip to content

Using remake to bypass re-discretizing over parameters causing an error #105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thompsonmj opened this issue May 25, 2022 · 9 comments
Closed

Comments

@thompsonmj
Copy link
Contributor

As a prerequisite to #104, the Remake with different parameter values example gives the following error on the solve step:

ERROR: MethodError: no method matching *(::Pair{Num, Float64}, ::Float64)

@xtalax
Copy link
Member

xtalax commented May 25, 2022

Sorry, this is a known issue with that tutorial - please see here for the updated version.

@ChrisRackauckas
Copy link
Member

Can we turn this into a more informative error message?

@thompsonmj
Copy link
Contributor Author

Sorry, this is a known issue with that tutorial - please see here for the updated version.

Thanks, that syntax works.

@xtalax
Copy link
Member

xtalax commented May 26, 2022

Can we turn this into a more informative error message?

Sure, where is remake defined?

@ChrisRackauckas
Copy link
Member

@thompsonmj
Copy link
Contributor Author

Shoot ... actually running with remake() doesn't correctly update new parameters in that example. It just uses the original parameters from the equation definition.

@YichengDWu
Copy link
Contributor

Shoot ... actually running with remake() doesn't correctly update new parameters in that example. It just uses the original parameters from the equation definition.

It's fixed later. Check again.

@thompsonmj
Copy link
Contributor Author

thompsonmj commented May 31, 2022

Updated and remake with EnsembleProblem are working. Thanks @MilkshakeForReal!

@YichengDWu
Copy link
Contributor

So you can close this issue now i guess

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants