Import public API from its owning module, not a re-exporter (#4880)

`ExplicitImports.check_all_explicit_imports_via_owners` and
`check_all_qualified_accesses_via_owners` both failed on `ModelingToolkit`
because ten bindings were reached through a package that merely forwards them:

  - `@add_kwonly`, `NullParameters`, `value` via `DiffEqBase` (owner `SciMLBase`)
  - `Operator`, `Term`, `_iszero`, `_isone` via `Symbolics` (owner `SymbolicUtils`)
  - `getname` via `Symbolics` (owner `SymbolicIndexingInterface`)
  - `maketerm`, `metadata` via `SymbolicUtils` (owner `TermInterface`)
  - `topological_sort`, `value`, `var_from_nested_derivative`, `schedule` via
    `ModelingToolkitBase` in the `StructuralTransformations` submodule
    (owners `Graphs`, `Symbolics`, `Symbolics`, `Base`)

Each name is now imported from the module that declares it. Every relocated
binding was checked to be `===` to the one previously used, so this is a pure
import-site change with no behaviour difference. `schedule` was unused and is
dropped rather than re-pointed.

Four of the moved names (`@add_kwonly`, `NullParameters`, `value`, `getname`)
plus `maketerm`/`metadata` are `public` at their owner but not at the
re-exporter, so this also drops the `*_are_public` findings from 57/91 to
53/89.

`TermInterface` becomes a direct dependency; it was already in the manifest
through `SymbolicUtils`.

Co-authored-by: ChrisRackauckas-Claude <accounts@chrisrackauckas.com>

Author: ChrisRackauckas-Claude

Project.toml

@@ -43,6 +43,7 @@ StaticArrays = "90137ffa-7385-5640-81b9-e52037218182"
 SymbolicIndexingInterface = "2efcf032-c050-4f8e-a9bb-153293bab1f5"
 SymbolicUtils = "d1185830-fcd6-423d-90d6-eec64667417b"
 Symbolics = "0c5d862f-8b57-4792-8d23-62f2024744c7"
+TermInterface = "8ea1fca8-c5ef-4a55-8b96-4e9afe9c9a3c"
 UnPack = "3a884ed6-31ef-47d7-9d2a-63182c4928ed"
 
 [weakdeps]
@@ -123,6 +124,7 @@ StochasticDiffEq = "6.82.0, 7"
 SymbolicIndexingInterface = "0.3.46"
 SymbolicUtils = "4.31"
 Symbolics = "7.32.1"
+TermInterface = "2"
 UnPack = "1"
 julia = "1.10"
 BenchmarkTools = "1"

src/ModelingToolkit.jl

@@ -16,10 +16,11 @@ end
 
 import SymbolicUtils
 import SymbolicUtils as SU
-import SymbolicUtils: iscall, arguments, operation, maketerm, promote_symtype,
+import SymbolicUtils: iscall, arguments, operation, promote_symtype,
     isadd, ismul, ispow, issym, FnType, isconst, BSImpl,
-    @rule, Rewriters, substitute, metadata, BasicSymbolic,
-    symtype
+    @rule, Rewriters, substitute, BasicSymbolic,
+    symtype, _iszero, _isone
+import TermInterface: maketerm, metadata
 using SymbolicUtils.Code
 import SymbolicUtils.Code: toexpr
 import SymbolicUtils.Rewriters: Chain, Postwalk, Prewalk, Fixpoint
@@ -31,6 +32,7 @@ using Graphs
 import OrderedCollections
 
 using SymbolicIndexingInterface
+using SymbolicIndexingInterface: getname
 using LinearAlgebra, SparseArrays
 using InteractiveUtils
 using DataStructures
@@ -56,12 +58,12 @@ using RuntimeGeneratedFunctions: drop_expr
 using Symbolics: degree, VartypeT, SymbolicT
 using Symbolics: parse_vars, value, @derivatives, get_variables,
     exprs_occur_in, symbolic_linear_solve, unwrap, wrap,
-    VariableSource, getname, variable, COMMON_ZERO,
+    VariableSource, variable, COMMON_ZERO,
     NAMESPACE_SEPARATOR, setdefaultval, Arr,
     hasnode, fixpoint_sub, CallAndWrap, SArgsT, SSym, STerm
 const NAMESPACE_SEPARATOR_SYMBOL = Symbol(NAMESPACE_SEPARATOR)
 import Symbolics: rename, get_variables!, _solve, hessian_sparsity,
-    jacobian_sparsity, isaffine, islinear, _iszero, _isone,
+    jacobian_sparsity, isaffine, islinear,
     tosymbol, lower_varname, diff2term, var_from_nested_derivative,
     BuildTargets, JuliaTarget, StanTarget, CTarget, MATLABTarget,
     ParallelForm, SerialForm, MultithreadedForm, build_function,
@@ -71,7 +73,7 @@ import Symbolics: rename, get_variables!, _solve, hessian_sparsity,
 import ModelingToolkitBase as MTKBase
 import SimpleNonlinearSolve
 
-import DiffEqBase: @add_kwonly
+import SciMLBase: @add_kwonly
 @reexport using Symbolics
 @reexport using UnPack
 @reexport using ModelingToolkitBase

src/discretedomain.jl

@@ -1,4 +1,5 @@
-using Symbolics: Operator, Num, Term, value, recursive_hasoperator
+using Symbolics: Num, value, recursive_hasoperator
+using SymbolicUtils: Operator, Term
 
 MTKBase.ShiftIndex() = MTKBase.ShiftIndex(MTKTearing.Inferred())
 MTKBase.Sample() = MTKBase.Sample(MTKTearing.InferredDiscrete())

src/linearization.jl

@@ -139,7 +139,7 @@ function linearization_function(
         initialization_abstol = 1.0e-5,
         initialization_reltol = 1.0e-3,
         op = Dict{SymbolicT, SymbolicT}(),
-        p = DiffEqBase.NullParameters(),
+        p = SciMLBase.NullParameters(),
         zero_dummy_der = false,
         initialization_solver_alg = nothing,
         autodiff = AutoForwardDiff(),
@@ -957,7 +957,7 @@ lsys_sym, _ = ModelingToolkit.linearize_symbolic(cl, [f.u], [p.x])
 function linearize(
         sys, lin_fun::LinearizationFunction; t = 0.0,
         op = Dict(), allow_input_derivatives = false,
-        p = DiffEqBase.NullParameters()
+        p = SciMLBase.NullParameters()
     )
     if op isa LinearizationOpPoint && op.t isa AbstractVector
         ops = _build_op_from_solution(op)

src/problems/semilinearodeproblem.jl

@@ -142,7 +142,7 @@ end
             defs[par] = mat
         end
         cachelen = jac ? length(dvs) * length(eqs) : length(dvs)
-        defs[diffcache_par] = DiffCache(zeros(DiffEqBase.value(_u0_eltype), cachelen))
+        defs[diffcache_par] = DiffCache(zeros(SciMLBase.value(_u0_eltype), cachelen))
     end
     @set! sys.guesses = guess
     @set! sys.initial_conditions = defs

src/structural_transformation/StructuralTransformations.jl

@@ -3,20 +3,21 @@ module StructuralTransformations
 using Setfield: @set!, @set
 using UnPack: @unpack
 
-using Symbolics: unwrap, linear_expansion, VartypeT, SymbolicT
+using Symbolics: unwrap, linear_expansion, VartypeT, SymbolicT,
+    var_from_nested_derivative, value
 import Symbolics
 using SymbolicUtils
 using SymbolicUtils: BSImpl
 using SymbolicUtils.Code
 using SymbolicUtils.Rewriters
-using SymbolicUtils: maketerm, iscall, symtype
+using SymbolicUtils: iscall, symtype
+using TermInterface: maketerm
 import SymbolicUtils as SU
 import Moshi
 
 using ModelingToolkit
-using ModelingToolkitBase: System, AbstractSystem, var_from_nested_derivative, Differential,
+using ModelingToolkitBase: System, AbstractSystem, Differential,
     unknowns, equations, diff2term_with_unit,
-    value,
     operation, arguments, simplify, symbolic_linear_solve,
     isdiffeq, isdifferential, isirreducible,
     empty_substitutions, get_substitutions,
@@ -25,17 +26,17 @@ using ModelingToolkitBase: System, AbstractSystem, var_from_nested_derivative, D
     ExtraEquationsSystemException,
     ExtraVariablesSystemException,
     invalidate_cache!, Shift,
-    topological_sort,
     filter_kwargs, lower_varname_with_unit,
     setio,
     has_equations, observed,
-    Schedule, schedule, iscomplete, get_schedule, VariableUnshifted,
+    Schedule, iscomplete, get_schedule, VariableUnshifted,
     VariableShift, DerivativeDict, shift2term, simplify_shifts,
     distribute_shift
 
 using BipartiteGraphs
 import BipartiteGraphs: invview, complete, IncrementalCycleTracker, add_edge_checked!
 using Graphs
+using Graphs: topological_sort
 using ModelingToolkit: mtkcompile!
 using SymbolicIndexingInterface: symbolic_type, ArraySymbolic, NotSymbolic, getname