Skip to content

Commit 54b3390

Browse files
authored
remove true_jacobian Broyden from default alg (#577)
This method is unlikely to be much better than normal Broyden or Klement and requires a pseudoinverse which is really bad for sparse jacobians. As such, this PR removes it when we aren't preferring the Simple algs
1 parent 27c1f52 commit 54b3390

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

src/poly_algs.jl

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -72,7 +72,6 @@ function FastShortcutNonlinearPolyalg(
7272
if T <: Complex
7373
algs = (
7474
Broyden(; autodiff),
75-
Broyden(; init_jacobian = Val(:true_jacobian), autodiff),
7675
Klement(; linsolve, autodiff),
7776
NewtonRaphson(; common_kwargs...)
7877
)
@@ -81,7 +80,6 @@ function FastShortcutNonlinearPolyalg(
8180
start_index = u0_len !== nothing ? (u0_len 25 ? 4 : 1) : 1
8281
algs = (
8382
Broyden(; autodiff),
84-
Broyden(; init_jacobian = Val(:true_jacobian), autodiff),
8583
Klement(; linsolve, autodiff),
8684
NewtonRaphson(; common_kwargs...),
8785
NewtonRaphson(; common_kwargs..., linesearch = BackTracking()),

0 commit comments

Comments
 (0)