Merge pull request #65 from SciML/qa-run-qa-v16-explicit-imports

QA: run_qa v1.6 form + ExplicitImports

Author: ChrisRackauckas

Project.toml

@@ -13,6 +13,7 @@ SparseArrays = "2f01184e-e22b-5df5-ae63-d93ebab69eaf"
 AMD = "0.5"
 ForwardDiff = "1"
 KLU = "0.6"
+LinearAlgebra = "1"
 MuladdMacro = "0.2.4"
 PrecompileTools = "1"
 Random = "1"

src/PureKLU.jl

@@ -14,17 +14,16 @@ ordering is currently approximated by natural ordering; blocks of size
 """
 module PureKLU
 
-using SparseArrays
-using SparseArrays: SparseMatrixCSC
-using LinearAlgebra
+using SparseArrays: SparseArrays, SparseMatrixCSC
+using LinearAlgebra: LinearAlgebra, Adjoint, Transpose
 using MuladdMacro: @muladd  # kept for future opt-in FMA; see src/Kernel.jl
-# Full `using` (not a selective `using PrecompileTools: ...`) so the bare
-# `PrecompileTools` name is in scope: the `@setup_workload`/`@compile_workload`
-# macro expansion in PrecompileTools 1.0.x references it directly, so a
-# selective import breaks loading on the lower compat bound (see Downgrade CI).
-using PrecompileTools
+# The bare `PrecompileTools` name must stay in scope: the
+# `@setup_workload`/`@compile_workload` macro expansion in PrecompileTools 1.0.x
+# references it directly, so importing the macros without the module name breaks
+# loading on the lower compat bound (see Downgrade CI).
+using PrecompileTools: PrecompileTools, @setup_workload, @compile_workload
 import SparseArrays: nnz, nonzeros
-import Base: (\), size, getproperty, setproperty!, propertynames, show
+import Base: size, getproperty, setproperty!, show
 
 export klu, klu!
 export klu_factor!, klu_refactor!, klu_analyze!, solve!

test/qa/Project.toml

@@ -2,7 +2,6 @@
 Aqua = "4c88cf16-eb10-579e-8560-4a9242c79595"
 JET = "c3a54625-cd67-489e-a8e7-0a5a0ff4e31b"
 PureKLU = "0c0d3e7f-3a8b-4f7e-b6f1-9a4d2e7c1f01"
-SafeTestsets = "1bc83da4-3b8d-516f-aca4-4fe02f6d838f"
 SciMLTesting = "09d9d899-5365-40a9-917a-5f67fddea283"
 Test = "8dfed614-e22c-5e08-85e1-65c5234f0b40"
 
@@ -12,7 +11,6 @@ PureKLU = {path = "../.."}
 [compat]
 Aqua = "0.8"
 JET = "0.9,0.10,0.11"
-SafeTestsets = "0.1, 1"
-SciMLTesting = "1"
+SciMLTesting = "1.6"
 Test = "1"
 julia = "1.10"

test/qa/qa.jl

@@ -1,17 +1,21 @@
-using PureKLU
-using Aqua
+using SciMLTesting, PureKLU, Test
 using JET
-using Test
 
-@testset "Aqua" begin
-    Aqua.test_all(PureKLU; stale_deps = false, deps_compat = false)
-    # Genuine Aqua findings, marked broken pending fix — see
-    # https://github.com/SciML/PureKLU.jl/issues/62
-    @test_broken false  # stale_deps: ForwardDiff declared in [deps] but unused — see https://github.com/SciML/PureKLU.jl/issues/62
-    @test_broken false  # deps_compat: missing [compat] for LinearAlgebra — see https://github.com/SciML/PureKLU.jl/issues/62
-    @test_broken false  # deps_compat: missing [compat] for extra Pkg — see https://github.com/SciML/PureKLU.jl/issues/62
-end
-
-@testset "JET" begin
-    @test_broken false  # JET: toplevel error at src/PureKLU.jl:27 — parens around (\) in `import Base` — see https://github.com/SciML/PureKLU.jl/issues/62
-end
+run_qa(
+    PureKLU;
+    explicit_imports = true,
+    ei_kwargs = (;
+        no_stale_explicit_imports = (;
+            # `@muladd` is imported from MuladdMacro but currently unused; kept as a
+            # deliberate dependency for future opt-in FMA (see src/Kernel.jl).
+            ignore = (Symbol("@muladd"),),
+        ),
+        all_qualified_accesses_are_public = (;
+            # Cross-package non-public names accessed qualified and needed:
+            #   AdjointFactorization / TransposeFactorization (LinearAlgebra) are
+            #     used under `isdefined` guards for cross-version compatibility.
+            #   RefValue (Base) is used as a struct field type.
+            ignore = (:AdjointFactorization, :TransposeFactorization, :RefValue),
+        ),
+    ),
+)