Skip to content

Commit 354e00d

Browse files
authored
Merge pull request #477 from SciML/loglevel_reparam
Making loglevel work correctly for reparametrization
2 parents 2bdf754 + 8123880 commit 354e00d

File tree

3 files changed

+5
-4
lines changed

3 files changed

+5
-4
lines changed

Project.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@ Pkg = "1.10, 1.11"
4848
PrecompileTools = "1.2"
4949
Primes = "0.5"
5050
Random = "1.10, 1.11"
51-
RationalFunctionFields = "0.2.2"
51+
RationalFunctionFields = "0.2.3"
5252
SpecialFunctions = "2"
5353
SymbolicUtils = "4"
5454
Symbolics = "7"

src/parametrizations.jl

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ The function accepts the following optional arguments.
158158
159159
- `seed`: A float in the range from 0 to 1, random seed (default is `seed = 42`).
160160
- `prob_threshold`: The probability of correctness (default is `prob_threshold = 0.99`).
161+
- `loglevel`: the level of logs to be displayed (default is `Logging.Info`).
161162
162163
## Example
163164
@@ -208,7 +209,7 @@ end
208209

209210
function _reparametrize_global(ode::ODE{P}; prob_threshold = 0.99, seed = 42) where {P}
210211
Random.seed!(seed)
211-
id_funcs = find_identifiable_functions(
212+
id_funcs = _find_identifiable_functions(
212213
ode,
213214
with_states = true,
214215
simplify = :strong,

test/raw_generators.jl

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -47,14 +47,14 @@ import Groebner
4747
gb = Groebner.groebner(eqs, ordering = Groebner.DegRevLex())
4848
# GB is linear
4949
@test length(gb) == length(gens(parent(eqs[1])))
50-
expected = 9202476
50+
expected = 9220151
5151
str = join(map(string, eqs), ",")
5252
@info "" length(str)
5353
@test abs(length(str) - expected) / expected * 100 < 5
5454

5555
# Part 2: over Q
5656
eqs = fractionfree_generators_raw(rff.mqs)[1]
57-
expected = 21486079
57+
expected = 14652203
5858
str = join(map(string, eqs), ",")
5959
@info "" length(str)
6060
@test abs(length(str) - expected) / expected * 100 < 5

0 commit comments

Comments
 (0)