update bytesio to binaryio

[zhengwj533]

This pull request updates file handling in the store_file method for both PostgreSQL and S3 providers to improve compatibility and correctness when working with binary file streams. The key changes include switching from io.BytesIO/BytesIO to the more general BinaryIO type and updating file size calculation logic for PostgreSQL.

Use BytesIO for small in-memory buffers; switch to file-based BinaryIO for large files.

Changes to file handling:

• py/core/providers/file/postgres.py:

  • Changed the type of the file_content parameter in store_file and _write_lobject methods from io.BytesIO to BinaryIO for broader compatibility with binary streams. [1] [2]
  • Updated file size calculation logic in store_file to use seek and tell instead of getbuffer().nbytes, ensuring compatibility with any BinaryIO implementation.

• py/core/providers/file/s3.py:

  • Updated the file_content parameter in the store_file method from BytesIO to BinaryIO to align with the PostgreSQL provider and support a wider range of binary file streams.

---

Important

Update store_file methods in PostgreSQL and S3 providers to use BinaryIO for better binary stream compatibility.

• File Handling:
  • postgres.py: Changed file_content type in store_file and _write_lobject from io.BytesIO to BinaryIO. Updated file size calculation in store_file to use seek and tell.
  • s3.py: Changed file_content type in store_file from BytesIO to BinaryIO.

^{This description was created by for fbbc488. You can customize this summary. It will automatically update as commits are pushed.}

[ellipsis-dev]

Important

Looks good to me! 👍

Reviewed everything up to fbbc488 in 1 minute and 14 seconds. Click for details.

• Reviewed 50 lines of code in 3 files
• Skipped 0 files when reviewing.
• Skipped posting 5 draft comments. View those below.
• Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.

1. README.md:1

• Draft comment:
  Consider adding a newline at the end of the file for better POSIX compatibility.
• Reason this comment was not posted:
  Confidence changes required: 33% <= threshold 50% None

2. py/core/providers/file/postgres.py:94

• Draft comment:
  Updating the parameter type from BytesIO to BinaryIO improves generality.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, explaining the change made in the code. It doesn't provide a suggestion, ask for confirmation, or point out a potential issue. Therefore, it should be removed according to the rules.

3. py/core/providers/file/postgres.py:98

• Draft comment:
  Using seek(0,2) and tell() for file size calculation is more general; ensure the stream supports seek.
• Reason this comment was not posted:
  Comment looked like it was already resolved.

4. py/core/providers/file/postgres.py:113

• Draft comment:
  Type annotation update in '_write_lobject' to BinaryIO ensures consistency with 'store_file'.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% This comment is purely informative, as it only states what the change is without providing any actionable feedback or suggestions. It doesn't ask for confirmation or suggest improvements.

5. py/core/providers/file/s3.py:69

• Draft comment:
  Changing the 'file_content' parameter type to BinaryIO enhances consistency with the PostgreSQL provider; ensure the stream supports seek operations.
• Reason this comment was not posted:
  Comment did not seem useful. Confidence is useful = 0% <= threshold 50% The comment is informative and suggests ensuring that the stream supports seek operations, which is a form of asking the author to double-check something. This violates the rules against asking for confirmation or ensuring behavior.

Workflow ID: wflow_dmOR3Q5boIqxhSnX

^{You can customize by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.}