Skip to content

Conversation

@NolanTrem
Copy link
Contributor

@NolanTrem NolanTrem commented Aug 17, 2025

Closes #2241


Important

Add support for GPT-5 by updating model handling and configuration files, and updating dependencies.

  • Behavior:
    • Add support for gpt-5 in _get_base_args() in openai.py by adjusting token handling logic.
    • Update fast_llm, quality_llm, and vlm to gpt-5 models in r2r.toml.
  • Dependencies:
    • Update openai dependency to >=1.99.0 in pyproject.toml.
  • Versioning:
    • Bump version to 3.6.6 in pyproject.toml.

This description was created by Ellipsis for 8f37e0a. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed everything up to 4989fc8 in 1 minute and 2 seconds. Click for details.
  • Reviewed 66 lines of code in 3 files
  • Skipped 1 files when reviewing.
  • Skipped posting 3 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. py/core/providers/llm/openai.py:402
  • Draft comment:
    Include 'gpt-5' in the model check to use 'max_completion_tokens'. Ensure that omitting temperature and top_p for these models is intentional.
  • Reason this comment was not posted:
    Comment looked like it was already resolved.
2. pyproject.toml:20
  • Draft comment:
    Bump OpenAI dependency to >=1.99.0 to support GPT-5. Confirm this upgrade is compatible with all usages.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.
3. r2r/r2r.toml:12
  • Draft comment:
    Update LLM configurations for fast, quality, and vision models to GPT-5 variants. Ensure these new model strings are fully supported.
  • Reason this comment was not posted:
    Comment was not on a location in the diff, so it can't be submitted as a review comment.

Workflow ID: wflow_vnBwfiRIbVsu5zKc

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

Copy link
Contributor

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Important

Looks good to me! 👍

Reviewed 8f37e0a in 47 seconds. Click for details.
  • Reviewed 20 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 draft comments. View those below.
  • Modify your settings and rules to customize what types of comments Ellipsis leaves. And don't forget to react with 👍 or 👎 to teach Ellipsis.
1. py/core/providers/llm/openai.py:402
  • Draft comment:
    Formatting improvement: The multi-line generator expression is clearer. Confirm that checking for substrings 'o1', 'o3', and 'gpt-5' properly captures all GPT-5 variations (e.g., gpt-5-mini).
  • Reason this comment was not posted:
    Comment looked like it was already resolved.

Workflow ID: wflow_zLfJDRsOqhyqpLjW

You can customize Ellipsis by changing your verbosity settings, reacting with 👍 or 👎, replying to comments, or adding code review rules.

@NolanTrem NolanTrem merged commit bc5254f into main Aug 17, 2025
5 of 6 checks passed
@NolanTrem NolanTrem deleted the Nolan/GPT-5 branch August 17, 2025 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

GPT-5 Not supported

2 participants