Skip to content

Commit eb38191

Browse files
committed
refactor: tests remove np.array_equal and np.all functions
1 parent 3eb3c4a commit eb38191

File tree

4 files changed

+97
-98
lines changed

4 files changed

+97
-98
lines changed

tests/test_general_methods.py

Lines changed: 31 additions & 29 deletions
Original file line numberDiff line numberDiff line change
@@ -3,14 +3,13 @@
33
from NumpyDeque import NumpyDeque
44

55

6-
@pytest.fixture
7-
def empty_deque():
8-
return NumpyDeque(maxsize=5)
9-
10-
11-
@pytest.fixture
12-
def filled_deque():
13-
return NumpyDeque.array([1, 2, 3, 4, 5], maxsize=5)
6+
def test_custom_dtype():
7+
dtype = np.dtype([("field1", np.int32), ("field2", np.float64)])
8+
d = NumpyDeque(maxsize=5, dtype=dtype)
9+
d.put((1, 2.5))
10+
d.put((3, 4.5))
11+
assert d[0]["field1"] == 1
12+
assert d[1]["field2"] == 4.5
1413

1514

1615
def test_buffer_shift():
@@ -24,11 +23,11 @@ def test_buffer_shift():
2423
d.put(i)
2524
d.put(11) # shift occurs
2625
assert d._i == d._s
27-
assert np.all(d.deque == np.array([7, 8, 9, 10, 11]))
26+
assert (d.deque == np.array([7, 8, 9, 10, 11])).all()
2827
for i in range(6):
2928
d.putleft(i) # shift occurs always
3029
assert d._i == d._s
31-
assert np.all(d.deque == np.array([5, 4, 3, 2, 1]))
30+
assert (d.deque == np.array([5, 4, 3, 2, 1])).all()
3231

3332
array_like = [1, 2, 3, 4, 5]
3433
d = NumpyDeque.array(array_like, priority="right", _force_buffer_size=10)
@@ -40,11 +39,11 @@ def test_buffer_shift():
4039
d.put(i)
4140
d.put(10) # shift occurs
4241
assert d._i == d._s
43-
assert np.all(d.deque == np.array([6, 7, 8, 9, 10]))
42+
assert (d.deque == np.array([6, 7, 8, 9, 10])).all()
4443
d.putleft(0)
4544
d.putleft(1) # shift occurs
4645
assert d._i == d._s
47-
assert np.all(d.deque == np.array([1, 0, 6, 7, 8]))
46+
assert (d.deque == np.array([1, 0, 6, 7, 8])).all()
4847

4948
d = NumpyDeque.array(array_like, priority="left", _force_buffer_size=10)
5049
assert d._s == 3 # buffer shift index
@@ -55,12 +54,12 @@ def test_buffer_shift():
5554
d.put(i) # shift occurs
5655
d.put(8) # shift occurs
5756
assert d._i == d._s
58-
assert np.all(d.deque == np.array([4, 5, 6, 7, 8]))
57+
assert (d.deque == np.array([4, 5, 6, 7, 8])).all()
5958
for i in range(3):
6059
d.putleft(i)
6160
d.putleft(3) # shift occurs
6261
assert d._i == d._s
63-
assert np.all(d.deque == np.array([3, 2, 1, 0, 4]))
62+
assert (d.deque == np.array([3, 2, 1, 0, 4])).all()
6463

6564
d = NumpyDeque.array(array_like, priority="leftonly", _force_buffer_size=10)
6665
assert d._s == 5 # buffer shift index
@@ -71,43 +70,46 @@ def test_buffer_shift():
7170
d.put(i) # shift occurs always
7271
d.put(11) # shift occurs
7372
assert d._i == d._s
74-
assert np.all(d.deque == np.array([7, 8, 9, 10, 11]))
73+
assert (d.deque == np.array([7, 8, 9, 10, 11])).all()
7574
for i in range(5):
7675
d.putleft(i)
7776
d.putleft(5) # shift occurs
7877
assert d._i == d._s
79-
assert np.all(d.deque == np.array([5, 4, 3, 2, 1]))
78+
assert (d.deque == np.array([5, 4, 3, 2, 1])).all()
8079

8180

8281
def test_invalid_priority():
8382
with pytest.raises(ValueError):
8483
NumpyDeque(maxsize=5, priority="invalid")
8584

8685

87-
def test_clear(filled_deque):
88-
filled_deque.clear()
89-
assert len(filled_deque) == 0
86+
def test_clear():
87+
d = NumpyDeque.array([1, 2, 3, 4, 5])
88+
d.clear()
89+
assert len(d) == 0
9090

9191

92-
def test_copy(filled_deque):
93-
copied_deque = filled_deque.copy()
94-
assert len(copied_deque) == len(filled_deque)
95-
assert np.array_equal(copied_deque.deque, filled_deque.deque)
96-
assert copied_deque is not filled_deque
92+
def test_copy():
93+
d = NumpyDeque.array([1, 2, 3, 4, 5])
94+
copied_deque = d.copy()
95+
assert len(copied_deque) == len(d)
96+
assert (copied_deque.deque == d.deque).all()
97+
assert copied_deque is not d
9798

9899

99-
def test_reverse(filled_deque):
100-
filled_deque.reverse()
101-
assert np.array_equal(filled_deque.deque, [5, 4, 3, 2, 1])
100+
def test_reverse():
101+
d = NumpyDeque.array([1, 2, 3, 4, 5])
102+
d.reverse()
103+
assert (d.deque == [5, 4, 3, 2, 1]).all()
102104

103105

104106
def test_abs():
105107
d = NumpyDeque.array([-1, -2, 3, -4, 5], maxsize=5)
106108
d.abs()
107-
assert np.array_equal(d.deque, [1, 2, 3, 4, 5])
109+
assert (d.deque == [1, 2, 3, 4, 5]).all()
108110

109111

110112
def test_sort():
111113
d = NumpyDeque.array([3, 1, 4, 2, 5], maxsize=5)
112114
d.sort()
113-
assert np.array_equal(d.deque, [1, 2, 3, 4, 5])
115+
assert (d.deque == [1, 2, 3, 4, 5]).all()

tests/test_initialization.py

Lines changed: 20 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -7,12 +7,12 @@ def test_initialization_array():
77
d = NumpyDeque.array(array_like)
88
assert len(d) == 5
99
assert d.maxsize == 5
10-
assert np.all(d.deque == np.array(array_like))
10+
assert (d.deque == np.array(array_like)).all()
1111

1212
d = NumpyDeque.array(array_like, maxsize=10)
1313
assert len(d) == 5
1414
assert d.maxsize == 10
15-
assert np.all(d.deque == np.array(array_like))
15+
assert (d.deque == np.array(array_like)).all()
1616

1717

1818
def test_empty_initialization():
@@ -31,13 +31,13 @@ def test_fill_initialization():
3131
d = NumpyDeque(maxsize=10, fill=1)
3232
assert len(d) == 10
3333
assert d.maxsize == 10
34-
assert np.all(d.deque == 1)
34+
assert (d.deque == 1).all()
3535
assert len(d.deque) == 10
3636

3737
d = NumpyDeque(maxsize=100, fill=2)
3838
assert len(d) == 100
3939
assert d.maxsize == 100
40-
assert np.all(d.deque == 2)
40+
assert (d.deque == 2).all()
4141
assert len(d.deque) == 100
4242

4343

@@ -58,14 +58,14 @@ def test_int64_initialization():
5858
assert d.dtype == np.int64
5959
assert len(d) == 10
6060
assert d.maxsize == 10
61-
assert np.all(d.deque == 1)
61+
assert (d.deque == 1).all()
6262
assert len(d.deque) == 10
6363

6464
d = NumpyDeque(maxsize=100, fill=2, dtype=np.int64)
6565
assert d.dtype == np.int64
6666
assert len(d) == 100
6767
assert d.maxsize == 100
68-
assert np.all(d.deque == 2)
68+
assert (d.deque == 2).all()
6969
assert len(d.deque) == 100
7070

7171

@@ -86,14 +86,14 @@ def test_float64_initialization():
8686
assert d.dtype == np.float64
8787
assert len(d) == 10
8888
assert d.maxsize == 10
89-
assert np.all(d.deque == 1.0)
89+
assert (d.deque == 1.0).all()
9090
assert len(d.deque) == 10
9191

9292
d = NumpyDeque(maxsize=100, fill=2, dtype=np.float64)
9393
assert d.dtype == np.float64
9494
assert len(d) == 100
9595
assert d.maxsize == 100
96-
assert np.all(d.deque == 2.0)
96+
assert (d.deque == 2.0).all()
9797
assert len(d.deque) == 100
9898

9999

@@ -132,31 +132,31 @@ def test_pad_initialization():
132132
assert d.buffer_size >= siz + 2 * pad
133133
assert len(d) == siz
134134
assert d.maxsize == siz
135-
assert np.all(d.deque == 1)
135+
assert (d.deque == 1).all()
136136

137137
siz = 100
138138
pad = 10
139139
d = NumpyDeque(maxsize=siz, fill=2, buffer_padding=pad)
140140
assert d.buffer_size >= siz + 2 * pad
141141
assert len(d) == siz
142142
assert d.maxsize == siz
143-
assert np.all(d.deque == 2)
143+
assert (d.deque == 2).all()
144144

145145
siz = 10
146146
pad = 100
147147
d = NumpyDeque(maxsize=siz, fill=1, buffer_padding=pad)
148148
assert d.buffer_size >= siz + 2 * pad
149149
assert len(d) == siz
150150
assert d.maxsize == siz
151-
assert np.all(d.deque == 1)
151+
assert (d.deque == 1).all()
152152

153153
siz = 100
154154
pad = 100
155155
d = NumpyDeque(maxsize=siz, fill=2, buffer_padding=pad)
156156
assert d.buffer_size >= siz + 2 * pad
157157
assert len(d) == siz
158158
assert d.maxsize == siz
159-
assert np.all(d.deque == 2)
159+
assert (d.deque == 2).all()
160160

161161

162162
def test_priority_initialization():
@@ -168,7 +168,7 @@ def test_priority_initialization():
168168
d = NumpyDeque(maxsize=10, fill=1, priority="right")
169169
assert len(d) == 10
170170
assert d.maxsize == 10
171-
assert np.all(d.deque == 1)
171+
assert (d.deque == 1).all()
172172
assert len(d.deque) == 10
173173

174174
d = NumpyDeque(maxsize=100, priority="right")
@@ -179,7 +179,7 @@ def test_priority_initialization():
179179
d = NumpyDeque(maxsize=100, fill=1, priority="right")
180180
assert len(d) == 100
181181
assert d.maxsize == 100
182-
assert np.all(d.deque == 1)
182+
assert (d.deque == 1).all()
183183
assert len(d.deque) == 100
184184

185185
d = NumpyDeque(maxsize=10, priority="rightonly")
@@ -190,7 +190,7 @@ def test_priority_initialization():
190190
d = NumpyDeque(maxsize=10, fill=1, priority="rightonly")
191191
assert len(d) == 10
192192
assert d.maxsize == 10
193-
assert np.all(d.deque == 1)
193+
assert (d.deque == 1).all()
194194
assert len(d.deque) == 10
195195

196196
d = NumpyDeque(maxsize=100, priority="rightonly")
@@ -201,7 +201,7 @@ def test_priority_initialization():
201201
d = NumpyDeque(maxsize=100, fill=1, priority="rightonly")
202202
assert len(d) == 100
203203
assert d.maxsize == 100
204-
assert np.all(d.deque == 1)
204+
assert (d.deque == 1).all()
205205
assert len(d.deque) == 100
206206

207207
d = NumpyDeque(maxsize=10, priority="left")
@@ -212,7 +212,7 @@ def test_priority_initialization():
212212
d = NumpyDeque(maxsize=10, fill=1, priority="left")
213213
assert len(d) == 10
214214
assert d.maxsize == 10
215-
assert np.all(d.deque == 1)
215+
assert (d.deque == 1).all()
216216
assert len(d.deque) == 10
217217

218218
d = NumpyDeque(maxsize=100, priority="left")
@@ -223,7 +223,7 @@ def test_priority_initialization():
223223
d = NumpyDeque(maxsize=100, fill=1, priority="left")
224224
assert len(d) == 100
225225
assert d.maxsize == 100
226-
assert np.all(d.deque == 1)
226+
assert (d.deque == 1).all()
227227
assert len(d.deque) == 100
228228

229229
d = NumpyDeque(maxsize=10, priority="leftonly")
@@ -234,7 +234,7 @@ def test_priority_initialization():
234234
d = NumpyDeque(maxsize=10, fill=1, priority="leftonly")
235235
assert len(d) == 10
236236
assert d.maxsize == 10
237-
assert np.all(d.deque == 1)
237+
assert (d.deque == 1).all()
238238
assert len(d.deque) == 10
239239

240240
d = NumpyDeque(maxsize=100, priority="leftonly")
@@ -245,5 +245,5 @@ def test_priority_initialization():
245245
d = NumpyDeque(maxsize=100, fill=1, priority="leftonly")
246246
assert len(d) == 100
247247
assert d.maxsize == 100
248-
assert np.all(d.deque == 1)
248+
assert (d.deque == 1).all()
249249
assert len(d.deque) == 100

0 commit comments

Comments
 (0)