Skip to content

Commit 00fa7da

Browse files
committed
Enable tokenizers in shortfin packages on Linux x86_64.
1 parent 7e62c25 commit 00fa7da

File tree

1 file changed

+12
-2
lines changed

1 file changed

+12
-2
lines changed

shortfin/build_tools/build_linux_package.sh

+12-2
Original file line numberDiff line numberDiff line change
@@ -37,13 +37,22 @@ REPO_ROOT="$(cd "$THIS_DIR"/../../ && pwd)"
3737
SCRIPT_NAME="$(basename $0)"
3838
ARCH="$(uname -m)"
3939

40-
# Note: we can switch to https://github.com/nod-ai/base-docker-images as needed for extra deps.
41-
MANYLINUX_DOCKER_IMAGE="${MANYLINUX_DOCKER_IMAGE:-quay.io/pypa/manylinux_2_28_${ARCH}:latest}"
4240
PYTHON_VERSIONS="${OVERRIDE_PYTHON_VERSIONS:-cp311-cp311 cp312-cp312 cp313-cp313}"
4341
OUTPUT_DIR="${OUTPUT_DIR:-${THIS_DIR}/wheelhouse}"
4442
CACHE_DIR="${CACHE_DIR:-}"
4543
SHORTFIN_ENABLE_TRACING="${SHORTFIN_ENABLE_TRACING:-ON}"
4644

45+
# Our x86_64 dockerfile contains dependencies needed to build the tokenizer
46+
# library (rust), so enable tokenizers by default on x86_64.
47+
# TODO: publish a multi-platform manylinux image and include more deps in all platforms (rust, ccache, etc.)
48+
if [[ "${ARCH}" == "x86_64" ]]; then
49+
MANYLINUX_DOCKER_IMAGE="${MANYLINUX_DOCKER_IMAGE:-ghcr.io/nod-ai/manylinux_x86_64@sha256:4acf83343706d1e37252d6001ded3c97a73bc38620580f855b4e65e35ddc5681}"
50+
SHORTFIN_ENABLE_TOKENIZERS="${SHORTFIN_ENABLE_TOKENIZERS:-ON}"
51+
else
52+
MANYLINUX_DOCKER_IMAGE="${MANYLINUX_DOCKER_IMAGE:-quay.io/pypa/manylinux_2_28_${ARCH}:latest}"
53+
SHORTFIN_ENABLE_TOKENIZERS="${SHORTFIN_ENABLE_TOKENIZERS:-OFF}"
54+
fi
55+
4756
function run_on_host() {
4857
echo "Running on host"
4958
echo "Launching docker image ${MANYLINUX_DOCKER_IMAGE}"
@@ -69,6 +78,7 @@ function run_on_host() {
6978
-e "OVERRIDE_PYTHON_VERSIONS=${PYTHON_VERSIONS}" \
7079
-e "OUTPUT_DIR=${OUTPUT_DIR}" \
7180
-e "SHORTFIN_ENABLE_TRACING=${SHORTFIN_ENABLE_TRACING}" \
81+
-e "SHORTFIN_ENABLE_TOKENIZERS=${SHORTFIN_ENABLE_TOKENIZERS}" \
7282
${extra_args} \
7383
"${MANYLINUX_DOCKER_IMAGE}" \
7484
-- ${THIS_DIR}/${SCRIPT_NAME}

0 commit comments

Comments
 (0)