Skip to content

Commit d727a26

Browse files
committed
Download into shortfin/version_info.json.
1 parent 04f68d6 commit d727a26

File tree

3 files changed

+7
-4
lines changed

3 files changed

+7
-4
lines changed

.github/workflows/build_packages.yml

+4-4
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ jobs:
2525
echo "shark_package_version=${shark_package_version}" >> $GITHUB_OUTPUT
2626
cat << EOF > ./version_info.json
2727
{
28-
"package-version": "${shark_package_version}",
28+
"package-version": "${shark_package_version}"
2929
}
3030
EOF
3131
cat ./version_info.json
3232
- name: Upload version_info.json
3333
uses: actions/upload-artifact@50769540e7f4bd5e21e526ee35c689e35e0d6874 # v4.4.0
3434
with:
35-
name: version_info.json
35+
name: version_info
3636
path: version_info.json
3737

3838
build_packages:
@@ -67,8 +67,8 @@ jobs:
6767
- name: Download version_info.json
6868
uses: actions/download-artifact@fa0a91b85d4f404e444e00e005971372dc801d16 # v4.1.8
6969
with:
70-
name: version_info.json
71-
path: version_info.json
70+
name: version_info
71+
path: shortfin/
7272

7373
- name: Build shortfin (Linux x86_64, ${{ matrix.python-version }})
7474
if: "matrix.package == 'shortfin' && matrix.build-family == 'linux-x86_64'"

shortfin/.gitignore

+2
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
# Local-only config options
2+
version_info.json

shortfin/setup.py

+1
Original file line numberDiff line numberDiff line change
@@ -164,6 +164,7 @@ def find_git_version():
164164
PACKAGE_VERSION = version_info.get("package-version")
165165
if not PACKAGE_VERSION:
166166
PACKAGE_VERSION = f"0.dev0+{git_version or '0'}"
167+
print(f"Using PACKAGE_VERSION: '{PACKAGE_VERSION}'")
167168

168169

169170
def maybe_nuke_cmake_cache(cmake_build_dir):

0 commit comments

Comments
 (0)