Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtered format: leaflet-providers need updating #886

Open
krabina opened this issue Dec 19, 2024 · 8 comments · May be fixed by #901
Open

Filtered format: leaflet-providers need updating #886

krabina opened this issue Dec 19, 2024 · 8 comments · May be fixed by #901
Labels

Comments

@krabina
Copy link
Contributor

krabina commented Dec 19, 2024

Setup

  • MW version: 1.39
  • DB (MySQL etc.):
  • PHP version: 7.4
  • SMW version: 4.2
  • SRF version: 4.2
  • Browsers and versions (if applicable):

Issue

The maps view in the filtered format does work with leaflet maps. If you select 'OpenStreetMap.Mapnik' as srfgMapProvider the Maps are working as expected:
https://www.verwaltungspreis.gv.at/Wien

However, if you select "BasemapAT.basemap" or "BasemapAT.grau", only some tiles are shown:
https://test.knowledge.wiki/MapsTestFiltered

The maps are working in the maps extension:
https://test.knowledge.wiki/MapsTestStatisch

But not in the filtered map view (that does not use the maps extension).

@krabina krabina added the bug label Dec 19, 2024
@krabina
Copy link
Contributor Author

krabina commented Dec 19, 2024

@krabina
Copy link
Contributor Author

krabina commented Dec 19, 2024

Using the version from Maps does not work in filtered, btw. Then no tile is being displayed.

@gesinn-it-gea
Copy link
Member

In https://test.knowledge.wiki/MapsTestFiltered you see a lot of JS errors:

image

@gesinn-it-gea
Copy link
Member

@gesinn-it-gea
Copy link
Member

@gesinn-it-gea
Copy link
Member

is available. Seems to be an issue with the map service

@krabina
Copy link
Contributor Author

krabina commented Dec 19, 2024

Understandable, the links should be mapsneu.wien.gv.at ...
https://cdn.basemap.at/basemap.at_URL_Umstellung_2023.pdf
Which I updated a while ago: https://github.com/leaflet-extras/leaflet-providers/blob/master/leaflet-providers.js#L864

@krabina
Copy link
Contributor Author

krabina commented Dec 19, 2024

so probably these need to be updated:

"@types/leaflet-providers": "^1.1.0",

@krabina krabina changed the title Filtered format: Maps view does not work with Basemap.AT anymore Filtered format: leaflet-providers need updating Dec 19, 2024
@krabina krabina linked a pull request Jan 24, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants