fix ansible-lint errors

Author: s1-nathangerhart

roles/s1_agent_common/handlers/main.yml

@@ -5,8 +5,8 @@
   ansible.builtin.service:
     name: "{{ s1_service_name }}"
     state: started
-    enabled: yes
-  become: yes
+    enabled: true
+  become: true
   when:
     - (s1_agent_auto_start | default("yes")) | bool
 
@@ -19,14 +19,14 @@
   until: "'Error: receive failed: Connection reset by peer' not in s1_ctl_control.stdout"
   retries: 15
   delay: 5
-  become: yes
+  become: true
   when:
     - (s1_agent_auto_start | default("yes")) | bool
 
 - name: Reboot Endpoint | Windows
   ansible.windows.win_reboot:
     reboot_timeout: 3600
-  become: yes
+  become: true
   listen: Reboot Node | Windows
   when:
     - not s1_common_skip_reboot
@@ -37,7 +37,7 @@
   ansible.windows.win_shell: Start-Sleep -Seconds 5 ; Restart-Computer -Force
   async: 1
   poll: 0
-  changed_when: yes
+  changed_when: true
   listen: Reboot Node | Windows | Unit Testing
   when:
     - not s1_common_skip_reboot

roles/s1_agent_common/meta/main.yml

@@ -19,7 +19,7 @@ galaxy_info:
   # - CC-BY-4.0
   license: license (GPL-3.0-or-later)
 
-  min_ansible_version: '2.9'
+  min_ansible_version: "2.9"
 
   # If this a Container Enabled role, provide the minimum Ansible Container version.
   # min_ansible_container_version:
@@ -33,9 +33,9 @@ galaxy_info:
   platforms:
     - name: EL
       versions:
-        - '6'
-        - '7'
-        - '8'
+        - "6"
+        - "7"
+        - "8"
     - name: Ubuntu
       versions:
         - trusty # 14.04
@@ -46,9 +46,9 @@ galaxy_info:
         - hirsute # 20.04
     - name: Windows
       versions:
-        - '2016'
-        - '2019'
-        - '2022'
+        - "2016"
+        - "2019"
+        - "2022"
 
   galaxy_tags:
     - edr

roles/s1_agent_common/tasks/main.yml

@@ -3,7 +3,7 @@
 
 - name: Gather required facts
   ansible.builtin.setup:
-    gather_subset: '{{ default_gather_subset + (role_gather_subset | default([])) }}'
+    gather_subset: "{{ default_gather_subset + (role_gather_subset | default([])) }}"
   tags:
     - s1_gather_facts
 
@@ -27,11 +27,11 @@
     - name: Endpoint details
       ansible.builtin.debug:
         msg:
-          - 'Ansible Distribution: {{ ansible_distribution }}'
-          - 'Ansible Distribution Version: {{ ansible_distribution_version }}'
-          - 'Ansible Distribution Major Version: {{ ansible_distribution_major_version }}'
-          - 'Ansible OS Family: {{ ansible_os_family }}'
-          - 'Ansible System: {{ ansible_system }}'
+          - "Ansible Distribution: {{ ansible_distribution }}"
+          - "Ansible Distribution Version: {{ ansible_distribution_version }}"
+          - "Ansible Distribution Major Version: {{ ansible_distribution_major_version }}"
+          - "Ansible OS Family: {{ ansible_os_family }}"
+          - "Ansible System: {{ ansible_system }}"
 
     - name: Variables will be loaded from the first matching file in vars
       ansible.builtin.debug:
@@ -44,7 +44,7 @@
           - "{{ ansible_system | replace(' ', '_') | lower }}.yml"
 
 - name: Set distribution variables
-  ansible.builtin.include_vars: '{{ loop_vars }}'
+  ansible.builtin.include_vars: "{{ loop_vars }}"
   with_first_found:
     - files:
         - "{{ ansible_distribution | lower | replace(' ', '_') }}_{{ ansible_distribution_version }}.yml"
@@ -53,11 +53,11 @@
         - "{{ ansible_os_family | replace(' ', '_') | lower }}_{{ ansible_distribution_major_version }}.yml"
         - "{{ ansible_os_family | replace(' ', '_') | lower }}.yml"
         - "{{ ansible_system | replace(' ', '_') | lower }}.yml"
-      skip: yes
+      skip: true
       paths:
-        - 'vars'
+        - vars
   loop_control:
     loop_var: loop_vars
-    label: '{{ loop_vars | basename }}'
+    label: "{{ loop_vars | basename }}"
   tags:
     - always

roles/s1_agent_common/vars/debian.yml

@@ -6,4 +6,4 @@ s1_package_name: sentinelagent
 # OS service manager name for the SentinelOne service
 s1_service_name: sentinelone.service
 # Name of the handler task to start the SentinelOne service
-s1_service_handler_name: 'Start SentinelOne service | {{ ansible_system }}'
+s1_service_handler_name: Start SentinelOne service | {{ ansible_system }}

roles/s1_agent_common/vars/main.yml

@@ -35,6 +35,6 @@ apt_pkg_mgrs:
 
 # Facts to gather for all roles
 default_gather_subset:
-  - '!all'
-  - '!hardware'
+  - "!all"
+  - "!hardware"
   - min

roles/s1_agent_common/vars/redhat.yml

@@ -6,4 +6,4 @@ s1_package_name: SentinelAgent
 # OS service manager name for the SentinelOne service
 s1_service_name: sentinelone.service
 # Name of the handler task to start the SentinelOne service
-s1_service_handler_name: 'Start SentinelOne service | {{ ansible_system }}'
+s1_service_handler_name: Start SentinelOne service | {{ ansible_system }}

roles/s1_agent_common/vars/redhat_6.yml

@@ -6,4 +6,4 @@ s1_package_name: SentinelAgent
 # OS service manager name for the SentinelOne service
 s1_service_name: sentineld
 # Name of the handler task to start the SentinelOne service
-s1_service_handler_name: 'Start SentinelOne service | {{ ansible_os_family }} {{ ansible_distribution_major_version }}'
+s1_service_handler_name: Start SentinelOne service | {{ ansible_os_family }} {{ ansible_distribution_major_version }}

roles/s1_agent_common/vars/suse.yml

@@ -6,4 +6,4 @@ s1_package_name: SentinelAgent
 # OS service manager name for the SentinelOne service
 s1_service_name: sentinelone.service
 # Name of the handler task to start the SentinelOne service
-s1_service_handler_name: 'Start SentinelOne service | {{ ansible_system }}'
+s1_service_handler_name: Start SentinelOne service | {{ ansible_system }}

roles/s1_agent_common/vars/windows.yml

@@ -6,7 +6,7 @@ s1_package_name: Sentinel Agent
 # OS service manager name for the SentinelOne service
 s1_service_name: SentinelAgent
 # Name of the handler task to restart the endpoint
-s1_reboot_handler_name: "Reboot Node | {{ ansible_os_family }}"
+s1_reboot_handler_name: Reboot Node | {{ ansible_os_family }}
 # Convert the package version to match the version reported by Windows
 s1_agent_win_file_ver: '{{ "v" + (s1_agent_version + "_" + ansible_facts.architecture) | regex_replace("[\.-]", "_") }}'