Skip to content

Commit f1cc653

Browse files
committed
EBML: Fix warnings
1 parent f7f8153 commit f1cc653

File tree

4 files changed

+11
-10
lines changed

4 files changed

+11
-10
lines changed

src/ebml/mod.rs

+3-2
Original file line numberDiff line numberDiff line change
@@ -13,9 +13,10 @@ pub use tag::EbmlTag;
1313
/// An EBML file
1414
#[derive(LoftyFile, Default)]
1515
#[lofty(read_fn = "read::read_from")]
16+
// TODO: #[lofty(internal_write_module_do_not_use_anywhere_else)]
1617
pub struct EbmlFile {
17-
/// An ID3v2 tag
18-
#[lofty(tag_type = "Id3v2")]
18+
/// An EBML tag
19+
#[lofty(tag_type = "Ebml")]
1920
pub(crate) ebml_tag: Option<EbmlTag>,
2021
/// The file's audio properties
2122
pub(crate) properties: EbmlProperties,

src/ebml/properties.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ use crate::properties::FileProperties;
55
pub struct EbmlProperties {}
66

77
impl From<EbmlProperties> for FileProperties {
8-
fn from(input: EbmlProperties) -> Self {
8+
fn from(_input: EbmlProperties) -> Self {
99
todo!()
1010
}
1111
}

src/ebml/read.rs

+1-1
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ use crate::probe::ParseOptions;
44

55
use std::io::{Read, Seek};
66

7-
pub(super) fn read_from<R>(reader: &mut R, parse_options: ParseOptions) -> Result<EbmlFile>
7+
pub(super) fn read_from<R>(_reader: &mut R, _parse_options: ParseOptions) -> Result<EbmlFile>
88
where
99
R: Read + Seek,
1010
{

src/ebml/tag/mod.rs

+6-6
Original file line numberDiff line numberDiff line change
@@ -24,27 +24,27 @@ impl TagExt for EbmlTag {
2424
todo!()
2525
}
2626

27-
fn contains<'a>(&'a self, key: Self::RefKey<'a>) -> bool {
27+
fn contains<'a>(&'a self, _key: Self::RefKey<'a>) -> bool {
2828
todo!()
2929
}
3030

3131
fn is_empty(&self) -> bool {
3232
todo!()
3333
}
3434

35-
fn save_to(&self, file: &mut File) -> std::result::Result<(), Self::Err> {
35+
fn save_to(&self, _file: &mut File) -> std::result::Result<(), Self::Err> {
3636
todo!()
3737
}
3838

39-
fn dump_to<W: Write>(&self, writer: &mut W) -> std::result::Result<(), Self::Err> {
39+
fn dump_to<W: Write>(&self, _writer: &mut W) -> std::result::Result<(), Self::Err> {
4040
todo!()
4141
}
4242

43-
fn remove_from_path<P: AsRef<Path>>(&self, path: P) -> std::result::Result<(), Self::Err> {
43+
fn remove_from_path<P: AsRef<Path>>(&self, _path: P) -> std::result::Result<(), Self::Err> {
4444
todo!()
4545
}
4646

47-
fn remove_from(&self, file: &mut File) -> std::result::Result<(), Self::Err> {
47+
fn remove_from(&self, _file: &mut File) -> std::result::Result<(), Self::Err> {
4848
todo!()
4949
}
5050

@@ -81,7 +81,7 @@ impl SplitTag for EbmlTag {
8181
impl MergeTag for SplitTagRemainder {
8282
type Merged = EbmlTag;
8383

84-
fn merge_tag(self, tag: Tag) -> Self::Merged {
84+
fn merge_tag(self, _tag: Tag) -> Self::Merged {
8585
todo!()
8686
}
8787
}

0 commit comments

Comments
 (0)