Skip to content
This repository was archived by the owner on Jan 18, 2023. It is now read-only.

Commit c4704f1

Browse files
committed
Trimmed unused functions and dependencies.
1 parent 2bb5d90 commit c4704f1

File tree

2 files changed

+3
-37
lines changed

2 files changed

+3
-37
lines changed

contracts/core/interfaces/ICoreIssuance.sol

-24
Original file line numberDiff line numberDiff line change
@@ -26,30 +26,6 @@ pragma solidity 0.4.24;
2626

2727
contract ICoreIssuance {
2828

29-
/**
30-
* Issue
31-
*
32-
* @param _setAddress Address of set to issue
33-
* @param _quantity Quantity of set to issue
34-
*/
35-
function issue(
36-
address _setAddress,
37-
uint _quantity
38-
)
39-
external;
40-
41-
/**
42-
* Function to convert Set Tokens into underlying components
43-
*
44-
* @param _setAddress The address of the Set token
45-
* @param _quantity The number of tokens to redeem
46-
*/
47-
function redeem(
48-
address _setAddress,
49-
uint _quantity
50-
)
51-
external;
52-
5329
/**
5430
* Issue internally. Can define who to issue to.
5531
*

test/core/extensions/coreIssuanceOrder.spec.ts

+3-13
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@ import { BigNumber } from "bignumber.js";
66
import { ether } from "../../utils/units";
77

88
// Types
9-
import { Address, Log } from "../../../types/common.js";
9+
import { Address } from "../../../types/common.js";
1010

1111
// Contract types
1212
import { CoreContract } from "../../../types/generated/core";
@@ -30,9 +30,7 @@ BigNumberSetup.configure();
3030
ChaiSetup.configure();
3131
const { expect, assert } = chai;
3232

33-
import { getFormattedLogsFromTxHash } from "../../logs/logUtils";
3433
import {
35-
extractNewSetTokenAddressFromLogs,
3634
IssuanceComponentDeposited,
3735
} from "../../logs/contracts/core";
3836

@@ -42,22 +40,14 @@ import {
4240
} from "../../utils/tokenAssertions";
4341

4442
import {
45-
DEFAULT_GAS,
4643
DEPLOYED_TOKEN_QUANTITY,
47-
NULL_ADDRESS,
48-
ZERO,
4944
} from "../../utils/constants";
5045

51-
import {
52-
assertLogEquivalence,
53-
} from "../../logs/logAssertions";
54-
5546
contract("CoreIssuance", (accounts) => {
5647
const [
5748
ownerAccount,
5849
takerAccount,
5950
makerAccount,
60-
unauthorizedAccount,
6151
] = accounts;
6252

6353
let core: CoreContract;
@@ -84,7 +74,7 @@ contract("CoreIssuance", (accounts) => {
8474
await coreWrapper.setDefaultStateAndAuthorizationsAsync(core, vault, transferProxy, setTokenFactory);
8575
});
8676

87-
describe.only("#fillOrder", async () => {
77+
describe("#fillOrder", async () => {
8878
let subjectCaller: Address;
8979
let subjectQuantityToIssue: BigNumber;
9080
let subjectSetToIssue: Address;
@@ -118,7 +108,7 @@ contract("CoreIssuance", (accounts) => {
118108
makerAccount,
119109
subjectSetToIssue,
120110
subjectQuantityToIssue,
121-
{ from: ownerAccount },
111+
{ from: subjectCaller },
122112
);
123113
}
124114

0 commit comments

Comments
 (0)