Skip to content

Commit b1743f2

Browse files
Disables extension auto-reload when saving files (isaac-sim#1788)
# Description Since extensions are now added to the app files, they get automatically reloaded when changes happen in the extension scripts. This feature is most likely not useful for Isaac Lab development workflows. This change disables the hot reload feature as it causes confusion and unnecessary reloading of the modules. Fixes isaac-sim#1779 <!-- As a practice, it is recommended to open an issue to have discussions on the proposed pull request. This makes it easier for the community to keep track of what is being developed or added, and if a given feature is demanded by more than one party. --> ## Type of change <!-- As you go through the list, delete the ones that are not applicable. --> - Bug fix (non-breaking change which fixes an issue) ## Checklist - [x] I have run the [`pre-commit` checks](https://pre-commit.com/) with `./isaaclab.sh --format` - [ ] I have made corresponding changes to the documentation - [x] My changes generate no new warnings - [ ] I have added tests that prove my fix is effective or that my feature works - [x] I have updated the changelog and the corresponding version in the extension's `config/extension.toml` file - [x] I have added my name to the `CONTRIBUTORS.md` or my name already exists there <!-- As you go through the checklist above, you can mark something as done by putting an x character in it For example, - [x] I have done this task - [ ] I have not done this task --> Co-authored-by: Mayank Mittal <[email protected]>
1 parent bb6d627 commit b1743f2

File tree

5 files changed

+15
-0
lines changed

5 files changed

+15
-0
lines changed

source/isaaclab/config/extension.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,5 +32,8 @@ modules = [
3232

3333
use_online_index=true
3434

35+
[core]
36+
reloadable = false
37+
3538
[[python.module]]
3639
name = "isaaclab"

source/isaaclab_assets/config/extension.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,6 +13,9 @@ keywords = ["kit", "robotics", "assets", "isaaclab"]
1313
[dependencies]
1414
"isaaclab" = {}
1515

16+
[core]
17+
reloadable = false
18+
1619
# Main python module this extension provides.
1720
[[python.module]]
1821
name = "isaaclab_assets"

source/isaaclab_mimic/config/extension.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,9 @@ keywords = ["extension", "template", "isaaclab"]
2020
"isaaclab_tasks" = {}
2121
# NOTE: Add additional dependencies here
2222

23+
[core]
24+
reloadable = false
25+
2326
[[python.module]]
2427
name = "isaaclab_mimic"
2528

source/isaaclab_rl/config/extension.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -16,5 +16,8 @@ keywords = ["robotics", "rl", "wrappers", "learning"]
1616
"isaaclab_assets" = {}
1717
"isaaclab_tasks" = {}
1818

19+
[core]
20+
reloadable = false
21+
1922
[[python.module]]
2023
name = "isaaclab_rl"

source/isaaclab_tasks/config/extension.toml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -15,5 +15,8 @@ keywords = ["robotics", "rl", "il", "learning"]
1515
"isaaclab" = {}
1616
"isaaclab_assets" = {}
1717

18+
[core]
19+
reloadable = false
20+
1821
[[python.module]]
1922
name = "isaaclab_tasks"

0 commit comments

Comments
 (0)