From 46d5169807616ecfe624d0c6acee228049fc8945 Mon Sep 17 00:00:00 2001 From: Jenny Shen Date: Fri, 26 Apr 2024 16:20:57 -0400 Subject: [PATCH 1/3] Commit .ruby-version file --- .gitignore | 1 - .ruby-version | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) create mode 100644 .ruby-version diff --git a/.gitignore b/.gitignore index 2f92ac96b..f88dd2787 100644 --- a/.gitignore +++ b/.gitignore @@ -9,7 +9,6 @@ /tmp/ .byebug_history -.ruby-version coverage/* dev/flamegraph.svg dev/profile diff --git a/.ruby-version b/.ruby-version new file mode 100644 index 000000000..be94e6f53 --- /dev/null +++ b/.ruby-version @@ -0,0 +1 @@ +3.2.2 From e8d92f80ecbd32357d24118234a5417a3a7366a8 Mon Sep 17 00:00:00 2001 From: Jenny Shen Date: Thu, 4 Apr 2024 11:56:46 -0400 Subject: [PATCH 2/3] Remove ruby version in dev.yml will read from .ruby-version --- dev.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/dev.yml b/dev.yml index 1764c9af9..5242d7b7a 100644 --- a/dev.yml +++ b/dev.yml @@ -1,7 +1,7 @@ --- name: krane up: - - ruby: '3.2.2' # Matches gemspec + - ruby - bundler - podman - kind: From 6e0bd6076664a179500e9435aa4e643d7afa5674 Mon Sep 17 00:00:00 2001 From: Jenny Shen Date: Thu, 4 Apr 2024 13:33:00 -0400 Subject: [PATCH 3/3] Remove TargetRubyVersion in RuboCop config reads from required_ruby_version in RuboCop 1.61+ --- .rubocop.yml | 3 --- krane.gemspec | 2 +- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/.rubocop.yml b/.rubocop.yml index 31c3c0f12..576c4de1a 100644 --- a/.rubocop.yml +++ b/.rubocop.yml @@ -3,6 +3,3 @@ inherit_gem: Style/DateTime: Enabled: false - -AllCops: - TargetRubyVersion: 2.4 diff --git a/krane.gemspec b/krane.gemspec index ebbd0575c..fb594ae64 100644 --- a/krane.gemspec +++ b/krane.gemspec @@ -56,7 +56,7 @@ Gem::Specification.new do |spec| spec.add_development_dependency("byebug") spec.add_development_dependency("ruby-prof") spec.add_development_dependency("ruby-prof-flamegraph") - spec.add_development_dependency("rubocop", "~> 0.89.1") + spec.add_development_dependency("rubocop", "~> 1.61.0") spec.add_development_dependency("rubocop-shopify", "~> 1.0.5") spec.add_development_dependency("simplecov") end