Skip to content

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Let Text component support flex prop #178

Closed
selbekk opened this issue Nov 15, 2022 · 1 comment
Closed

Let Text component support flex prop #178

selbekk opened this issue Nov 15, 2022 · 1 comment

Comments

@selbekk
Copy link

selbekk commented Nov 15, 2022

Is there a way we can make the default Text-component support the flex prop?

Today, this doesn't work:

<Text flex="1">My text takes up all the space</Text>

But this does:

<Text style={{ flex: "1" }}>My text takes up all the space</Text>
@flexbox
Copy link

flexbox commented Mar 2, 2023

Hey @selbekk
Thank you for the issue

Have you read this thread? #132 (comment)

layout is not included in textRestyleFunctions

For now instead, of using createText you can "manually" create your Text component to include the props you want.

@Shopify Shopify locked and limited conversation to collaborators Mar 21, 2023
@fortmarek fortmarek converted this issue into discussion #244 Mar 21, 2023

This issue was moved to a discussion.

You can continue the conversation there. Go to discussion →

Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants