-
Notifications
You must be signed in to change notification settings - Fork 195
Syntax highlight for ERB in heredoc #2863
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Thank you for the feature suggestion! We should definitely handle ERB heredocs too. |
@vinistock I can try to make a PR for this. |
Awesome! If you hit any blockers, don't hesitate to ping the team in this issue. |
I added a PR. I was using this HAML support PR as a guideline. Please help review 🙏 |
This issue is being marked as stale because there was no activity in the last 2 months |
This issue is being marked as stale because there was no activity in the last 2 months |
I have checked that this feature is not already implemented
Use case
I'm writing a lot of my ViewComponent with inline
erb
as heredoc and it would be great if the syntax highlight works for it as well.Description
Based on the current grammar, using
ERB
in heredoc won't get syntax highlighted like the other supported language in this file.I tried with
HTML
and it worked only with the non Ruby part.It's quite odd that there are support for JS, GRAPHQL, and other languages but not ERB.
Implementation
We only need to add a configuration for ERB to the grammar file.
The text was updated successfully, but these errors were encountered: